8000 higher_order typedispatch fix by ljwolf · Pull Request #20 · pysal/libpysal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

higher_order typedispatch fix #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 7, 2017
Merged

higher_order typedispatch fix #20

merged 10 commits into from
Jul 7, 2017

Conversation

ljwolf
Copy link
Member
@ljwolf ljwolf commented Jun 27, 2017 •
edited
Loading

I'm quite frustrated I clobbered what looked like quite a bit of work in pysal/#922.

I'm pushing this here because now Github won't let me resurrect my dev branch on pysal proper without just pushing that PR again.

This fixes pysal/#944 by allowing any binary W to be higher-ordered. Also, it enforces that the source weights are binary.

We need to finish this reorg soon & plug all those tickets up when we can ☹️

@ljwolf ljwolf changed the title Higher order higher_order typedispatch fix Jun 27, 2017
@ljwolf ljwolf requested a review from sjsrey July 5, 2017 20:43
@ljwolf
Copy link
Member Author
ljwolf commented Jul 7, 2017 •
edited
Loading

@sjsrey if this is good, this is an update of pysal-#944 and should now be ready to merge if it's up to snuff in the review.

I suggest we merge the stuff (bugfixes/enhancements) here & backport at scipy?

sjsrey
sjsrey approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member
@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backporting at scipy is on my list.
8454

@sjsrey sjsrey merged commit d88196a into pysal:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjsrey sjsrey sjsrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Higher Order Weights from Queen Contiguity Weights - Unsupported sparse argument
2 participants
@ljwolf @sjsrey
0