PERF: eliminate redundant sorting #793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
commented
Jun 9, 2025
Comment on lines
-45
to
+50
| sorter = sparray.row.argsort(**argsort_kwds) | ||
| head = ids[sparray.row][sorter] | ||
| tail = ids[sparray.col][sorter] | ||
| data = sparray.data[sorter] | ||
| head = ids[sparray.row] | ||
| tail = ids[sparray.col] | ||
| data = sparray.data | ||
| else: | ||
| sorter = sparray.row.argsort(**argsort_kwds) | ||
| head = sparray.row[sorter] | ||
| tail = sparray.col[sorter] | ||
| data = sparray.data[sorter] | ||
| head = sparray.row | ||
| tail = sparray.col | ||
| data = sparray.data |
There was a problem hiding this comment.
Unnecessary as _resolve_islands does this. And if it does not go through there, it is done in clique resolution.
| @@ -1085,7 +1085,7 @@ def build_kernel( | |||
| coplanar=coplanar, | |||
| ) | |||
|
|
|||
| return cls.from_arrays(head, tail, weight) | |||
| return cls.from_arrays(head, tail, weight, is_sorted=True) | |||
There was a problem hiding this comment.
As mentioned above, output of _kernel is known to be sorted.
|
CI is not failing because of this but because of missing upper pin in numba-feedstock that is being resolved independently by others. |
jGaboardi
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
gwlearnbandwidth search, we generate quite large graphs and it turned out that the bottleneck is not model fitting but graph creation. Especially sorting and reindex we do, and which we do at multiple spots even though one shall be enough. Removing some obvious redundancies here but there's a likelihood that some other performance-focused PRs will follow.