Meg interest calculator #31

pauleveritt · 2022-10-22T12:31:10Z

Here's is a draft of the work I've done while processing the first PR for an example. It also includes a few of the examples in PyScript main.

It currently fails in my mocking of document. It's a good place for Fabio Rosado and I to start talking.

…t.values["calc"]. It's a good place to PR.

FabioRosado

Thanks for pushing this Paul! I had a quick look in the morning and finally got some time to go through it.

I've added a bunch of comments/suggestions, not sure if you want to add them all or if we should do it as a follow up? 🤔 I can also push them if you would like

.pre-commit-config.yaml

CONTRIBUTING.MD

FabioRosado · 2022-10-23T19:03:02Z

TODO.md

+## Eventually
+
+- Get nox to work with downloaded pyodide/pyscript
+- Get rid of Poetry


Most just asking - are you planning on using something else?

I'm up for listening to your POV. We can stick to Poetry. We can go back to just pip, perhaps with some pip extras. Or something else, as long as it doesn't put up a barrier for contribution.

I think it would be good to have users create a single env for this, personally I enjoy using conda with poetry but that might be too confusing for someone just starting. Simple pip could work and it would lower the entry barrier since folks won't need to learn a new tool that they might not know about

FabioRosado · 2022-10-23T19:04:55Z

codecov.yaml

+  status:
+    project:
+      default:
+        target: "100"


In another project I maintain we aim for 100% but sometimes this can be a bit hard to achieve, any opinions about going for maybe 98-99?

This is going to be a good conversation, perhaps in a ticket or discussions. There's coverage in the PSC itself, then there's coverage in examples. So my first question: do you want the same number for both? Or do you view them as different vis a vis coverage goals?

src/psc/gallery/examples/interest_calculator/index.html

src/psc/here.py

src/psc/pages/contributing.html

src/psc/templates/homepage.jinja2

I do this all the time. Ugh. Co-authored-by: Fábio Rosado <hello@fabiorosado.dev>

pauleveritt · 2022-11-16T17:07:50Z

src/psc/app.py

@@ -1,8 +1,8 @@
 """Provide a web server to browse the examples."""
 import contextlib
+from collections.abc import Iterator


This is a really good catch. I always get this wrong. I probably should write some flake8 extension that complains. 😀

I think this is specifically to latest python versions right?
I was used to do from typings import blah haha

pauleveritt · 2022-11-16T17:08:51Z

tests/test_resources.py

@@ -90,7 +90,7 @@ def test_html_page() -> None:
    """Make an instance of a .html Page resource and test it."""
    this_page = Page(path=PurePath("contributing"))
    assert this_page.title == "Contributing"
-    assert this_page.subtitle == "How to get involved in the PyCharm Collective."
+    assert this_page.subtitle == "How to get involved in the PyScript Collective."


New rule: Every time I do this, I owe you $20.

pauleveritt · 2022-11-16T17:09:54Z

tests/test_fixtures.py



-def test_fake_element_find_element(fake_document, fake_element) -> None:
+def test_fake_element_find_element(fake_document: FakeDocument, fake_element: function) -> None:


What's your feeling on my commitment to typing? Too much?

My plan is: actual examples don't have to use typing. Perhaps even - never use typing. But the PSC itself does aim for good typing coverage.

These are the type of issues I still need to see if I can make mypy happy.
In general I am in favor of typing, but I think in a lot of cases we will have mypy break for examples when we do Element it complains that its not defined.

Your idea is great, keeping the examples easy to follow for new folks is great and enforcing typing there will make things more complicated 😄

pauleveritt · 2022-11-17T23:12:51Z

tests/test_fixtures.py

+        Element # noqa
+
+
+def test_fake_element_installed(fake_element: function) -> None:


You annotated with function. Perhaps you meant Callable with the right params?

pauleveritt · 2022-11-17T23:17:32Z

tests/test_fixtures.py

+from psc.here import STATIC
+
+
+Element = cast("Unknown", "Element")


The addition of this line causes some tests to fail, as Element should only exist in tests that ask for the fake_element fixture.

… parsing of this example.

pauleveritt added 2 commits October 17, 2022 20:00

The loading of the local file wasn't needed.

0f986d3

Pushing a flavor with a broken test, where the mock does self.documen…

7b10927

…t.values["calc"]. It's a good place to PR.

pauleveritt requested a review from FabioRosado October 23, 2022 18:33

FabioRosado reviewed Oct 23, 2022

View reviewed changes

pauleveritt and others added 8 commits November 1, 2022 09:27

PyCharm -> PyScript

5a4bf0e

I do this all the time. Ugh. Co-authored-by: Fábio Rosado <hello@fabiorosado.dev>

Small styling tweaks and contributing docs

14415f8

Update example name

088a7ec

Update var names and set button as disabled by default

ed6c538

More tweaks to interest calculator

f96b6fd

update precommit

43970ee

Fix pre-commit issues

1c87074

Types

84dc20c

pauleveritt commented Nov 16, 2022

View reviewed changes

pauleveritt commented Nov 17, 2022

View reviewed changes

pauleveritt added 2 commits November 17, 2022 19:34

Cleaned up the styling. Fixed an issue with a BOM that was messing up…

0904f0f

… parsing of this example.

Merge branch 'main' into meg-interest-calculator

8c548f4

pauleveritt marked this pull request as ready for review November 19, 2022 14:04

pauleveritt merged commit 6e31573 into main Nov 19, 2022

pauleveritt deleted the meg-interest-calculator branch November 19, 2022 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meg interest calculator #31

Meg interest calculator #31



		def test_fake_element_find_element(fake_document, fake_element) -> None:
		def test_fake_element_find_element(fake_document: FakeDocument, fake_element: function) -> None:

		Element # noqa


		def test_fake_element_installed(fake_element: function) -> None:

		from psc.here import STATIC


		Element = cast("Unknown", "Element")

Meg interest calculator #31

Meg interest calculator #31

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment