8000 Set pitch by loyaniu · Pull Request #94 · pystage/pystage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set pitch #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Set pitch #94

wants to merge 3 commits into from

Conversation

loyaniu
Copy link
Contributor
@loyaniu loyaniu commented Jul 12, 2023

Used ffmpeg for implementation. I tried other modules like pydub, none of them works as good as ffmpeg.

If using ffmpeg, then this project needs come with ffmpeg for windows, linux, mac, or ...

@loyaniu
Copy link
Contributor Author
loyaniu commented Jul 12, 2023

Or there might be some modules come with ffmpeg inside, needs to be figured out later.

@kaiec kaiec requested a review from FlorianRupp July 19, 2023 17:18
@kaiec kaiec assigned kaiec and FlorianRupp and unassigned kaiec Jul 19, 2023
FlorianRupp
FlorianRupp requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor
@FlorianRupp FlorianRupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading the sound class. I have only 2 minor things to print warnings or raise exceptions (see comments)

@kaiec kaiec added missing block wontfix This will not be worked on labels Jun 10, 2024
@kaiec
Copy link
Contributor
kaiec commented Jun 10, 2024

Looked into this again. I really would like to avoid the dependency on ffmpeg, especially as changing the pitch is funny, but probably not something that breaks a project if it is not available. Therefore I would put this on hold for now.

@kaiec kaiec marked this pull request as draft June 17, 2024 16:21
@DaikoGames
Copy link

Well I would like to see this Block in Pystage, even though not everybody uses it, and it may not be the easiest task, or the best for the Programm, but still I think some People would like to use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRupp FlorianRupp FlorianRupp requested changes

Assignees
No one assigned
Labels
discussion missing block wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loyaniu @kaiec @DaikoGames @FlorianRupp
0