Removal of unused signed_struct to reduce OpenSSL requirement
#494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
10 tasks
* keep all logs in release build and default to DEBUG log output for demo (part of pyrsia#442) (pyrsia#480) * Provide and retrieve artifacts via the kademlia p2p network (pyrsia#477) * lookup blobs via kademlia content provisioning * use dial and identify to add new node to dht * add local peer_id to status * Update source folder readme with more terminology and sub-crate (pyrsia#446) Co-authored-by: Sudhindra Rao <41690+betarelease@users.noreply.github.com> Co-authored-by: Erwin Morrhey <erwin@lodgon.com> Co-authored-by: Sudhindra Rao <41690+betarelease@users.noreply.github.com> Co-authored-by: Erwin Morrhey <erwin@lodgon.com> * Bump clap from 3.1.5 to 3.1.6 (pyrsia#474) Bumps [clap](https://github.com/clap-rs/clap) from 3.1.5 to 3.1.6. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v3.1.5...v3.1.6) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump once_cell from 1.9.0 to 1.10.0 (pyrsia#485) Bumps [once_cell](https://github.com/matklad/once_cell) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/matklad/once_cell/releases) - [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md) - [Commits](matklad/once_cell@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: once_cell dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Introduce the `KeyBox` for consensus engine (pyrsia#464) * delete signed structs build passes * more traces of openssl * cargo fmt Co-authored-by: Erwin Morrhey <erwin@lodgon.com> Co-authored-by: Joeri Sykora <joeri@sertik.net> Co-authored-by: Chris Mc <christopherm@jfrog.com> Co-authored-by: Sudhindra Rao <41690+betarelease@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
👋 Hi, @AbhijithGanesh, I detected conflicts against the base branch. You'll want to sync 🔄 your branch with upstream! This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
fishseabowl
reviewed
Mar 16, 2022
fishseabowl
reviewed
Mar 16, 2022
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
==========================================
+ Coverage 59.24% 61.48% +2.23%
==========================================
Files 24 24
Lines 2184 1711 -473
==========================================
- Hits 1294 1052 -242
+ Misses 890 659 -231
Continue to review full report at Codecov.
|
tiainen
reviewed
Mar 17, 2022
|
Just so that I understand correctly, this PR will cause all metadata to be stored in plain unsigned JSON? |
|
👋 Hi, @AbhijithGanesh, I detected conflicts against the base branch. You'll want to sync 🔄 your branch with upstream! This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
…yrsia into openssl-patch-1
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
|
@prince-chrismc @fishseabowl please review |
fishseabowl
reviewed
Mar 26, 2022
fishseabowl
reviewed
Mar 26, 2022
Co-authored-by: Xuefei Han <xuefeih@jfrog.com>
|
I ll remove them |
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
…yrsia into openssl-patch-1
Co-authored-by: Xuefei Han <xuefeih@jfrog.com>
.github/workflows/rust.yml
Outdated
| @@ -186,4 +181,4 @@ jobs: | |||
| context: . | |||
| push: true | |||
| file: installers/docker/CodeCoverage.Dockerfile | |||
| tags: pyrsiaoss/codecoverage:1.0 | |||
| tags: pyrsiaoss/codecoverage:1.0 | |||
There was a problem hiding this comment.
This looks incorrect 🤔 this file does not need to be changed
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
…yrsia into openssl-patch-1
prince-chrismc
approved these changes
Mar 28, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhijith Ganesh 67182544+AbhijithGanesh@users.noreply.github.com
PR Checklist
cargo build. For major changes,cargo build --workspace --releaseis recommended.cargo test. This executes our automated unit tests.cargo test, I've runcargo clippycargo auditpyrsia/mainbranch.Description
Fixes #484
Closes #86
This PR deletes signed_struct, signed effectively removing the OpenSSL dependency for the Node.
Screenshots (optional)