8000 Add workaround for missing status checks in CI by prince-chrismc · Pull Request #700 · pyrsia/pyrsia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add workaround for missing status checks in CI #700

New issue

Have a question about this project? Sign up 8000 for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

Add workaround for missing status checks in CI #700

merged 1 commit into from
May 18, 2022

Conversation

prince-chrismc
Copy link
Contributor

Description

Follow #692 the new paths filter on the run lint workflow had some unintended side effects were required jobs were no longer being created. This implements the workaround documented by GitHub.

https://openssf.slack.com/archives/C0302CVKPA5/p1652658860960049

Screenshots (optional)

PR Checklist

@prince-chrismc prince-chrismc added the github_actions Pull requests that update GitHub Actions code label May 16, 2022
@prince-chrismc prince-chrismc changed the title Add workaround for missing status checks Add workaround for missing status checks in CI May 16, 2022
@prince-chrismc prince-chrismc requested review from a team, fishseabowl and AbhijithGanesh and removed request for a team May 16, 2022 15:40
@codecov
Copy link
codecov bot commented May 16, 2022 •
edited
Loading

Codecov Report

Merging #700 (942aa84) into main (79bbde4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #700   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files          33       33           
  Lines        2297     2297           
=======================================
  Hits         1392     1392           
  Misses        905      905

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bbde4...942aa84. Read the comment docs.

This was referenced May 18, 2022
Closed
Merged
sbtaylor15
sbtaylor15 approved these changes May 18, 2022 8000
View reviewed changes
Copy link
Contributor
@sbtaylor15 sbtaylor15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. interesting work around.

@fishseabowl fishseabowl merged commit 5cecf3f into pyrsia:main May 18, 2022
@prince-chrismc prince-chrismc deleted the no-job-checks branch May 18, 2022 17:35
@prince-chrismc
Copy link
Contributor Author

IT'S WORKING 🚀

image

@sbtaylor15 sbtaylor15 mentioned this pull request Jun 1, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betarelease betarelease betarelease approved these changes

@sbtaylor15 sbtaylor15 sbtaylor15 approved these changes

@fishseabowl fishseabowl fishseabowl approved these changes

@AbhijithGanesh AbhijithGanesh Awaiting requested review from AbhijithGanesh AbhijithGanesh is a code owner automatically assigned from pyrsia/collaborators

Assignees

@prince-chrismc prince-chrismc

Labels
github_actions Pull requests that update GitHub Actions code in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prince-chrismc @betarelease @sbtaylor15 @fishseabowl
0