8000 Fix docker build docs - mention jq as prerequisite by izderadicka · Pull Request #1095 · pyrsia/pyrsia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix docker build docs - mention jq as prerequisite #1095

New issue

Have a question 8000 about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix docker build docs - mention jq as prerequisite #1095

merged 2 commits into from
Sep 27, 2022

Conversation

izderadicka
Copy link
Contributor
@izderadicka izderadicka commented Sep 25, 2022 •
edited
Loading

jq is required in docker pipeline shell script

Fixes pyrsia/pyrsia/docs#

This PR clarifies documentation - jq is required for prototype docker build pipeline.

PR Checklist

@izderadicka izderadicka requested a review from a team as a code owner September 25, 2022 08:05
@izderadicka izderadicka requested review from tiainen and sbtaylor15 and removed request for a team September 25, 2022 08:05
@CLAassistant
Copy link
CLAassistant commented Sep 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@betarelease
Copy link
Member

Thanks for the PR and fixing an issue in our docs - @izderadicka

sbtaylor15
sbtaylor15 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor
@sbtaylor15 sbtaylor15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbtaylor15 sbtaylor15 enabled auto-merge (squash) September 27, 2022 16:46
@sbtaylor15 sbtaylor15 merged commit 7312ca4 into pyrsia:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betarelease betarelease betarelease approved these changes

@sbtaylor15 sbtaylor15 sbtaylor15 approved these changes

@tiainen tiainen Awaiting requested review from tiainen tiainen is a code owner automatically assigned from pyrsia/collaborators

Assignees

@izderadicka izderadicka

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izderadicka @CLAassistant @betarelease @sbtaylor15
0