8000 Dockerize Pyrsia Node by chris-crone · Pull Request #227 · pyrsia/pyrsia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dockerize Pyrsia Node #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the commun 8000 ity.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2022
Merged

Dockerize Pyrsia Node #227

merged 2 commits into from
Jan 18, 2022

Conversation

chris-crone
Copy link
Contributor

Closes: #224

  • Adds Dockerfile
  • Adds docker-compose.yml for easy build and deploy
  • Adds docker-bake.hcl which is useful for development
  • Adds get started guide to README
  • Adds simple CI to check that the image build works

To build and run the Pyrsia Node locally, just run docker compose up if you have Docker Desktop installed.

An example of what can be done is updating the Cargo.lock after a Cargo.toml change:

docker buildx bake updatelock

Note: I'm not a rust developer so how I'm handling caching should be checked.

@chris-crone
Add ability to build and run Node in Docker
220272d 
* Adds Dockerfile
* Adds docker-compose.yml for easy build and deploy
* Adds docker-bake.hcl which is useful for development

Signed-off-by: Chris Crone <christopher.crone@docker.com>
@CLAassistant
Copy link
CLAassistant commented Jan 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chris-crone chris-crone changed the title Compose Dockerize Pyrsia Node Jan 14, 2022
@chris-crone
Add CI to test Docker build
e752781 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
@chris-crone chris-crone mentioned this pull request Jan 14, 2022
Closed
@mgrand mgrand requested a review from a team January 14, 2022 21:20
sbtaylor15
sbtaylor15 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor
@sbtaylor15 sbt 8000 aylor15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@chris-crone
Copy link
Contributor Author

Thanks for the reviews @mgrand and @sbtaylor15!

What's the process for merging on this project? Is it 2 LGTMs and the PR contributor merges or do we need more consensus?

@tiainen
Copy link
Collaborator
tiainen commented Jan 18, 2022

@chris-crone We need at least 2 approvals and all checks to have passed. In other words, you are all good to merge.

@chris-crone chris-crone merged commit 5950a3a into pyrsia:main Jan 18, 2022
@sbtaylor15 sbtaylor15 mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an acc 700E ount? Sign in to comment
Reviewers

@mgrand mgrand mgrand approved these changes

@sbtaylor15 sbtaylor15 sbtaylor15 approved these changes

Assignees

@chris-crone chris-crone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a dockerized version of the Pyrsia node
5 participants
@chris-crone @CLAassistant @tiainen @mgrand @sbtaylor15
0