Support namedtuple and dataclass #41
Open
+119
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
yf225
approved these changes
May 14, 2025
jansel
requested changes
May 15, 2025
Comment on lines
+142
to
+147
| type_: type[object] | str = type(obj) | ||
| if isinstance(obj, tuple) and hasattr(obj, "_fields"): | ||
| # this is a namedtuple | ||
| type_ = "namedtuple" | ||
| elif dataclasses.is_dataclass(obj): | ||
| type_ = "dataclass" |
There was a problem hiding this comment.
Let's put this in the except block so the common case is faster.
| @@ -462,6 +469,12 @@ def _sequence_key(fn: Kernel, obj: Sequence) -> Hashable: | |||
| return type(obj), tuple([fn._specialization_key(item) for item in obj]) | |||
|
|
|||
|
|
|||
| def _mapping_key(fn: Kernel, obj: dict[str | int, object]) -> Hashable: | |||
| return type(obj), tuple( | |||
There was a problem hiding this comment.
Won't type(obj) always be dict? I think we need the original type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):