8000 Add pre-commit config and put dev dependencies in toml by drisspg · Pull Request #48 · pytorch-labs/helion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add pre-commit config and put dev dependencies in toml #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add pre-commit config and put dev dependencies in toml #48

wants to merge 2 commits into from

Conversation

drisspg
Copy link
Contributor
@drisspg drisspg commented May 16, 2025 •
edited
Loading

Stacked PRs:

Add pre-commit config and put dev dependencies in toml

drisspg added a commit that referenced this pull request May 16, 2025
@drisspg
Add pre-commit config and put dev dependencies in toml
16b1901 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from a177724 to 16b1901 Compare May 16, 2025 21:56
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 16, 2025
@drisspg drisspg mentioned this pull request May 16, 2025
Merged
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 16b1901 to f8402c7 Compare May 16, 2025 22:16
@oulgen
Copy link
Contributor
oulgen commented May 17, 2025 •
edited
Loading

I actually did this before, but pyre does not work with pre-commit, and having to run pre-commit and pyre separately is kinda annoying

pre-commit also does not work with mercurial repo which was annoying for me at least

@jansel
Copy link
Contributor
jansel commented May 17, 2025

Also failing tests?

@drisspg drisspg force-pushed the drisspg/stack/1 branch from f8402c7 to 752180f Compare May 17, 2025 00:55
drisspg added a commit that referenced this pull request May 17, 2025
@drisspg
Add pre-commit config and put dev dependencies in toml
752180f 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg changed the base branch from main to drisspg/stack/2 May 17, 2025 00:56
@drisspg
Copy link
Contributor Author
drisspg commented May 17, 2025

@oulgen So added ruff to pre-commit but not Pyre because like you said no support, IMO it is still helpful for formatting since I typically just run pre-commit -a to fix up all my stuff

@drisspg drisspg requested a review from oulgen May 17, 2025 01:13
oulgen
oulgen approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor
@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we still keep ruff stuff in lint.sh this is ok, hopefully this does not brick my mercurial checkout

drisspg added a commit that referenced this pull request May 17, 2025
@drisspg
Add pre-commit config and put dev dependencies in toml
3d80284 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 752180f to 3d80284 Compare May 17, 2025 02:25
drisspg added a commit that referenced this pull request May 17, 2025
@drisspg
Add pre-commit config and put dev dependencies in toml
476f037 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 3d80284 to 476f037 Compare May 17, 2025 02:27
drisspg added 2 commits May 16, 2025 19:27
@drisspg
Add the core properties to Config object
3c58320 
stack-info: PR: #49, branch: drisspg/stack/2
@drisspg
Add pre-commit config and put dev dependencies in toml
fa26f87 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 476f037 to fa26f87 Compare May 17, 2025 02:32
drisspg added a commit that referenced this pull request May 17, 2025
@drisspg
Add pre-commit config and put dev dependencies in toml
9b1c70c 
stack-info: PR: #48, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/2 branch from f8074ea to 9b1c70c Compare May 17, 2025 02:34
@drisspg drisspg closed this May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oulgen oulgen oulgen approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drisspg @oulgen @jansel @facebook-github-bot
0