8000 Add `hl.grid(...)` support by yf225 · Pull Request #59 · pytorch-labs/helion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add hl.grid(...) support #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 21, 2025
Merged

Add hl.grid(...) support #59

merged 14 commits into from
May 21, 2025

Conversation

yf225
Copy link
Contributor
@yf225 yf225 commented May 20, 2025

Currently only the leading dims of the index list can be grid index. Use case like x[.., i, ..] will be supported in a future PR.

@yf225 yf225 requested review from jansel, oulgen and drisspg May 20, 2025 03:37
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 20, 2025
drisspg
drisspg reviewed May 20, 2025
View reviewed changes
Copy link
Contributor
@drisspg drisspg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this it should be pretty straightforward to write a persistent grid right?

@yf225
Copy link
Contributor Author
yf225 commented May 20, 2025 •
edited by drisspg
Loading

So with this it should be pretty straightforward to write a persistent grid right?

@drisspg I believe so in general :)

@jansel
Copy link
Contributor
jansel commented May 20, 2025

So with this it should be pretty straightforward to write a persistent grid right?

I think we can auto-generate persistent kernels, so I actually plan to make a config flag for this.

jansel
jansel requested changes May 20, 2025
View reviewed changes
@yf225 yf225 changed the title Add hl.grid(...) support [WIP] Add hl.grid(...) support May 20, 2025
@yf225 yf225 changed the title [WIP] Add hl.grid(...) support Add hl.grid(...) support May 20, 2025
@yf225 yf225 requested a review from jansel May 20, 2025 21:39
yf225
yf225 commented May 20, 2025
View reviewed changes
@yf225 yf225 merged commit 9858b0c into main May 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@drisspg drisspg drisspg left review comments

@oulgen oulgen Awaiting requested review from oulgen

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yf225 @jansel @drisspg @facebook-github-bot
0