10000 Adjust rtol/atol for test_sum_keepdims by yf225 · Pull Request #14 · pytorch-labs/helion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjust rtol/atol for test_sum_keepdims #14

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Adjust rtol/atol for test_sum_keepdims #14

merged 1 commit into from
Apr 29, 2025

Conversation

yf225
Copy link
Contributor
@yf225 yf225 commented Apr 29, 2025 •
edited
Loading

test_sum_keepdims seems to fail the accuracy check occasionally:

======================================================================
FAIL: test_sum_keepdims (test_reductions.TestReductions.test_sum_keepdims)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/pytorch-labs/helion/test/test_reductions.py", line 97, in test_sum_keepdims
    torch.testing.assert_close(output, args[0].sum(0, keepdim=True))
  File "/opt/conda/envs/venv/lib/python3.12/site-packages/torch/testing/_comparison.py", line 1587, in assert_close
    raise error_metas[0].to_error(msg)
AssertionError: Tensor-likes are not close!

Mismatched elements: 1 / 512 (0.2%)
Greatest absolute difference: 1.33514404296875e-05 at index (0, 407) (up to 1e-05 allowed)
Greatest relative difference: 7.88162651588209e-06 at index (0, 407) (up to 1.3e-06 allowed)

This PR slightly increases the tolerance to make the test more consistently pass the accuracy check.

@yf225 yf225 requested a review from jansel April 29, 2025 03:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 29, 2025
@yf225 yf225 merged commit de2a3e5 into pytorch-labs:main Apr 29, 2025
2 checks passed
@jansel jansel deleted the test_sum_keepdims__tol_fix branch April 29, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yf225 @jansel @facebook-github-bot
0