8000 Add support for aten::select.int and aten::stack by abhi-iyer · Pull Request #116 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for aten::select.int and aten::stack #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 26, 2020
Merged

Add support for aten::select.int and aten::stack #116

merged 10 commits into from
Jun 26, 2020

Conversation

abhi-iyer
Copy link
Contributor
@abhi-iyer abhi-iyer commented Jun 26, 2020 •
edited
Loading

Description

Adds support for aten::select.int and aten::stack. Added test cases for these.

Added unsqueezeDims tool to unsqueeze Tensor at specified dimension.

(from @narendasan) Added unpadDims tool to squeeze Tensor (removes first redundant dimension).

Fixes #110
Fixes #115

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

abhi-iyer added 9 commits June 25, 2020 12:38
@abhi-iyer
fix(): need to fix gather converter
024a6b2 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
Merge branch 'master' of https://github.com/abhi-iyer/TRTorch
e3b0e53
@abhi-iyer
test(aten::select.int): added test for aten::select.int
d33ec82 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
feat(trt_util): from Naren, added unpadDims tool
164a1a6 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
feat(//core/conversion/converters/impl): select converter, which adds…
5151c34 
… support for aten::select.int

Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
refactor(): removed unecessary imports from aten::select.int converter
6659b44 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
8000 test(aten::stack): Added test for aten::stack
97c8f52 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
feat(//core/conversion/converters/impl): added support for aten::stack
415378e 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@abhi-iyer
tool(core/util/): added tool to unsqueeze dimensions at a specified i…
37c68d3 
…ndex

Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
@narendasan narendasan added the component: converters Issues re: Specific op converters label Jun 26, 2020
@narendasan
Copy link
Collaborator

Closes #110
Closes #115

narendasan
narendasan requested changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator
@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost ready to merge, I think it is worth having the single select test case as well.

@abhi-iyer
test(aten::select): added test case for single call to select
f594e43 
Signed-off-by: Abhiram Iyer <abhirami@nvidia.com>

Signed-off-by: Abhiram Iyer <abhi.iyer.ai@gmail.com>
narendasan
narendasan approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator
@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit be69060 into pytorch:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
component: converters Issues re: Specific op converters
Projects
None yet
Milestone
Support for RNNs and Tensor Loop Tran...
Development

Successfully merging this pull request may close these issues.

Add support for aten::stack Add support for aten::select.int
2 participants
@abhi-iyer @narendasan
0