8000 feat: support aten.amin dynamo converter by zewenli98 · Pull Request #2504 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support aten.amin dynamo converter #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat: support aten.amin dynamo converter #2504

merged 2 commits into from
Dec 5, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support aten.amin dynamo converter

Fixes #2493

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 requested a review from gs-olive November 29, 2023 23:59
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Nov 29, 2023
@zewenli98 zewenli98 requested a review from bowang007 November 29, 2023 23:59
@github-actions github-actions bot requested a review from peri044 November 29, 2023 23:59
@zewenli98 zewenli98 requested a review from apbose November 30, 2023 00:00
zewenli98
zewenli98 commented Nov 30, 2023
View reviewed changes
py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py
Comment on lines -958 to -965
def amax_param_validator(amax_node: Node) -> bool:
if len(amax_node.args) < 2:
_LOGGER.debug(
f"At least two args input and dim should be provided, but only got {len(amax_node.args)} args."
)
return False

return True
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the schema, this validator seems not necessary.

@zewenli98 zewenli98 mentioned this pull request Nov 30, 2023
Closed
gs-olive
gs-olive reviewed Nov 30, 2023
View reviewed changes
@zewenli98 zewenli98 requested a review from gs-olive November 30, 2023 22:43
@zewenli98 zewenli98 force-pushed the amin_dynamo_converter branch from 25222b8 to 8000 dbfc9e9 Compare November 30, 2023 22:44
gs-olive
gs-olive approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator
@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zewenli98 zewenli98 merged commit e3608a5 into pytorch:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

@bowang007 bowang007 Awaiting requested review from bowang007

@peri044 peri044 Awaiting requested review from peri044

@apbose apbose Awaiting requested review from apbose

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
4C25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.amin
4 participants
@zewenli98 @apbose @gs-olive @facebook-github-bot
0