8000 feat: Add bf16 support to cast converter by peri044 · Pull Request #3643 · pytorch/TensorRT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add bf16 support to cast converter #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

feat: Add bf16 support to cast converter #3643

merged 2 commits into from
Jul 4, 2025
+27 −2

Conversation

peri044
Copy link
Collaborator
@peri044 peri044 commented Jul 1, 2025

Description

Extend the cast converter to support BF16

Fixes #3637

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 1, 2025
@peri044 peri044 requested a review from narendasan July 1, 2025 16:58
@github-actions github-actions bot requested a review from apbose July 1, 2025 16:58
narendasan
narendasan approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator
@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component: converters Issues re: Specific op converters label Jul 3, 2025
@peri044 peri044 merged commit 6cf72ab into main Jul 4, 2025
67 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❓ [Question] Why is torch.bfloat16 excluded from the allowed_casts set ?
3 participants
@peri044 @narendasan @facebook-github-bot
0