8000 Fix visdom tests for `macos-latest` by trsvchn · Pull Request #2253 · pytorch/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix visdom tests for macos-latest #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2021
Merged

Fix visdom tests for macos-latest #2253

merged 3 commits into from
Oct 6, 2021

Conversation

trsvchn
Copy link
Collaborator
@trsvchn trsvchn commented Oct 6, 2021 •
edited
Loading

Fixes #2229 #2251

Description:

Remove -l {0} since we do not use miniconda anymore and setup bash as default shell for all steps.
This actually fixes visdom tests for macos

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Oct 6, 2021
@trsvchn trsvchn changed the title Fix shell for unit-tests steps Fix visdom tests for macos-latest Oct 6, 2021
@trsvchn trsvchn linked an issue Oct 6, 2021 that may be closed by this pull request
Broken CI on macosx with MNIST example #2251
Closed
vfdev-5
vfdev-5 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator
@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @trsvchn !

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 6, 2021 20:48
@vfdev-5 vfdev-5 merged commit f03d4d3 into pytorch:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
ci CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken CI on macosx with MNIST example CI is failing with Visdom tests on macosx
2 participants
@trsvchn @vfdev-5
0