8000 [skipci] [Doctest] added contrib regression (``FractionalBias``, ``FractionalAbsoluteError``, ``CanberraMetric``, ``GeometricMeanAbsoluteError``) by Ishan-Kumar2 · Pull Request #2323 · pytorch/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[skipci] [Doctest] added contrib regression (FractionalBias, FractionalAbsoluteError, CanberraMetric, GeometricMeanAbsoluteError) #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2021

Conversation

Ishan-Kumar2
Copy link
Contributor
@Ishan-Kumar2 Ishan-Kumar2 commented Nov 12, 2021

Addresses #2265

Description:
Added Doctests for FractionalBias, FractionalAbsoluteError, CanberraMetric, GeometricMeanAbsoluteError

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Nov 12, 2021
@sdesrozis
Copy link
Contributor

@Ishan-Kumar2 Thank you very much for your help. I left a few comments. Note that some tests are failing because of formatting (or a similar thing).

Copy link
Contributor
@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ishan-Kumar2 Thanks ! LGTM

@sdesrozis sdesrozis merged commit 992c0ee into pytorch:master Nov 13, 2021
@sdesrozis sdesrozis mentioned this pull request Nov 13, 2021
51 tasks
fco-dv pushed a commit to fco-dv/ignite that referenced this pull request Nov 23, 2021
…actionalAbsoluteError``, ``CanberraMetric``, ``GeometricMeanAbsoluteError``) (pytorch#2323)

* added doctest for contrib regression metrics

* removed Engine definition and variable name changes

* added import of contrib.regression

Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
Ishan-Kumar2 added a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
…actionalAbsoluteError``, ``CanberraMetric``, ``GeometricMeanAbsoluteError``) (pytorch#2323)

* added doctest for contrib regression metrics

* removed Engine definition and variable name changes

* added import of contrib.regression

Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: contrib Contrib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0