8000 Added score_sign to add_early_stopping_by_val_score and gen_save_best_models_by_val_score by Hummer12007 · Pull Request #2929 · pytorch/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added score_sign to add_early_stopping_by_val_score and gen_save_best_models_by_val_score #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2023
Merged

Added score_sign to add_early_stopping_by_val_score and gen_save_best_models_by_val_score #2929

merged 8 commits into from
Apr 26, 2023

Conversation

Hummer12007
Copy link
Contributor
@Hummer12007 Hummer12007 commented Apr 21, 2023 •
edited
Loading

Description: added a score_sign argument to add_early_stopping_by_val_score to support easy setup of early stopping by loss.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Apr 21, 2023
@Hummer12007 Hummer12007 force-pushed the patch-1 branch 2 times, most recently from ddb9378 to 04d3de1 Compare April 21, 2023 17:40
vfdev-5
vfdev-5 reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator
@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Hummer12007 and sorry for delay!
Let's see if CI is passing, otherwise looks good to me

@vfdev-5
Copy link
Collaborator
vfdev-5 commented Apr 25, 2023 •
edited
Loading

@Hummer12007 seems like code formatting checker is not happy. Please run the following locally and update the PR:

bash ./tests/run_code_style.sh install
bash ./tests/run_code_style.sh fmt

Hummer12007 and others added 2 commits April 26, 2023 01:48
@Hummer12007
Fmt fix
0ba32fe
@Hummer12007 @vfdev-5
Update ignite/contrib/engines/common.py
6d8d098 
Co-authored-by: vfdev <vfdev.5@gmail.com>
vfdev-5
vfdev-5 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator
@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Hummer12007 !

@vfdev-5 vfdev-5 merged commit 7bafab7 into pytorch:master Apr 26, 2023
@vfdev-5 vfdev-5 changed the title Added score_sign to add_early_stopping_by_val_score Added score_sign to add_early_stopping_by_val_score and gen_save_best_models_by_val_score Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: contrib Contrib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hummer12007 @vfdev-5
0