8000 [Dynamo] Fix refleak in DynamicShapesMiscTests.test_custom_module_free_dynamic_shapes · Issue #120631 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Dynamo] Fix refleak in DynamicShapesMiscTests.test_custom_module_free_dynamic_shapes #120631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamwen42 opened this issue Feb 26, 2024 · 1 comment
Closed

[Dynamo] Fix refleak in DynamicShapesMiscTests.test_custom_module_free_dynamic_shapes #120631

williamwen42 opened this issue Feb 26, 2024 · 1 comment
Assignees
@williamwen42
Labels
dynamo-must-fix These bugs affect TorchDynamo reliability. module: dynamic shapes module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@williamwen42
Copy link
Member
williamwen42 commented Feb 26, 2024 •
edited by pytorch-bot bot
Loading

#120459 introduced a refleak test in dynamo. DynamicShapesMiscTests.test_custom_module_free_dynamic_shapes is currently being xfailed when z3-solver is present in the system.

cc @ezyang @msaroufim @bdhirsh @anijain2305 @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng
@williamwen42 williamwen42 added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module oncall: pt2 module: dynamo dynamo-must-fix These bugs affect TorchDynamo reliability. labels Feb 26, 2024
@williamwen42 williamwen42 self-assigned this Feb 26, 2024
@ezyang
Copy link
Contributor
ezyang commented Feb 27, 2024

feel free to bounce if you determine it is specifically dynamic shapes related

@williamwen42 williamwen42 mentioned this issue Mar 19, 2024
Closed
williamwen42 added a commit that referenced this issue Mar 20, 2024
@williamwen42
Update base for Update on "[dynamo] use proxies to nn.Module in dynam…
985dd14 
…o generated GraphModules"


Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes #120631 (not entirely sure why)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
williamwen42 added a commit that referenced this issue Mar 20, 2024
@williamwen42
Update on "[dynamo] use proxies to nn.Module in dynamo generated Grap…
7bb33b1 
…hModules"


Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes #120631 (not entirely sure why)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Mar 21, 2024
@williamwen42 @pytorchmergebot
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
2352471 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this issue Mar 22, 2024
8000 @williamwen42 @facebook-github-bot
use proxies to nn.Module in dynamo generated GraphModules (#120756)
9d64293 
Summary:
Fixes remaining refleaks found when debugging pytorch/pytorch#119607, tests added in pytorch/pytorch#120657.

Also fixes some tests that xfail: pytorch/pytorch#120631 (not entirely sure why), but introduced tests now fail.

X-link: pytorch/pytorch#120756
Approved by: https://github.com/jansel

Reviewed By: huydhn

Differential Revision: D55225127

Pulled By: williamwen42

fbshipit-source-id: 0d402deb4246d981304985761b94f637970fabce
pytorch-bot bot pushed a commit that referenced this issue Apr 22, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
6cec57d 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
williamwen42 added a commit that referenced this issue May 15, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
3a08393 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
@williamwen42 williamwen42 mentioned this issue May 15, 2024
Merged
williamwen42 added a commit that referenced this issue May 15, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
40f60a6 
…120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
atalman pushed a commit that referenced this issue May 22, 2024
@williamwen42
[dynamo] use proxies to nn.Module in dynamo generated GraphModules (#…
6cd59f1 
…126332)

* [dynamo] use proxies to nn.Module in dynamo generated GraphModules (#120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel

* [dynamo] use proxies to nn.Module in dynamo generated GraphModules (#120756)

Fixes remaining refleaks found when debugging #119607, tests added in #120657.

Also fixes some tests that xfail: #120631 (not entirely sure why), but introduced tests now fail.

Pull Request resolved: #120756
Approved by: https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamwen42 williamwen42

Labels
dynamo-must-fix These bugs affect TorchDynamo reliability. module: dynamic shapes module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @williamwen42
0