8000 Remove pre-cxx11 from the documentation and tutorials · Issue #149550 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove pre-cxx11 from the documentation and tutorials #14 8000 9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman opened this issue Mar 19, 2025 · 0 comments · May be fixed by #149849
Closed

Remove pre-cxx11 from the documentation and tutorials #149550

atalman opened this issue Mar 19, 2025 · 0 comments · May be fixed by #149849
Labels
module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
2.7.0

Comments

@atalman
Copy link
Contributor
atalman commented Mar 19, 2025 •
edited
Loading

🐛 Describe the bug

Please see: #123649
and https://dev-discuss.pytorch.org/t/pytorch-linux-wheels-switching-to-new-wheel-build-platform-manylinux-2-28-on-november-12-2024/2581/2

Pytorch is using D_GLIBCXX_USE_CXX11_ABI=1 and Manylinux 2.28
Hence we should remove the usage of PRE_CXX11_ABI from the documents

Example: https://pytorch.org/cppdocs/installing.html#system-requirements

Versions

2.7.0

cc @svekars @sekyondaMeta @AlannaBurke
@atalman atalman added module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 19, 2025
@atalman atalman added this to the 2.7.0 milestone Mar 19, 2025
@AlannaBurke AlannaBurke mentioned this issue Mar 21, 2025
Closed
copley added a commit to copley/pytorch that referenced this issue Mar 24, 2025
@copley
Fix pytorch#149550: Remove pre-cxx11 from documentation and tutorials
a6ebfd3
@copley copley mentioned this issue Mar 24, 2025
Open
pytorchbot pushed a commit that referenced this issue Mar 25, 2025
@AlannaBurke @pytorchbot
Removing doc references to PRE_CXX11_ABI. (#149756)
48cfa93 
Fixes #149550

Pull Request resolved: #149756
Approved by: https://github.com/svekars, https://github.com/atalman

(cherry picked from commit 43ee67e)
@pytorchbot pytorchbot mentioned this issue Mar 25, 2025
Merged
malfet pushed a commit that referenced this issue Mar 25, 2025
@pytorchbot @AlannaBurke
Removing doc references to PRE_CXX11_ABI. (#149952)
1f612da 
Removing doc references to PRE_CXX11_ABI. (#149756)

Fixes #149550

Pull Request resolved: #149756
Approved by: https://github.com/svekars, https://github.com/atalman

(cherry picked from commit 43ee67e)

Co-authored-by: Alanna Burke <burkealanna@meta.com>
@atalman atalman mentioned this issue Apr 3, 2025
Closed
65 tasks
amathewc pushed a commit to amathewc/pytorch that referenced this issue Apr 17, 2025
@AlannaBurke @amathewc
Removing doc references to PRE_CXX11_ABI. (pytorch#149756)
3a3d502 
Fixes pytorch#149550

Pull Request resolved: pytorch#149756
Approved by: https://github.com/svekars, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
2.7.0
1 participant
@atalman
0