8000 function signature doesn't match docstring · Issue #2667 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

function signature doesn't match docstring #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chasezheng opened this issue Sep 7, 2017 · 2 comments
Closed

function signature doesn't match docstring #2667

chasezheng opened this issue Sep 7, 2017 · 2 comments

Comments

@chasezheng
Copy link

pytorch/torch/autograd/variable.py

Line 128 in 459cc5a

def backward(self, gradient=None, retain_graph=None, create_graph=None, retain_variables=None):

@alykhantejani
Copy link
Contributor

hmm yeah this looks a bit wrong - will send a PR with doc changes

@alykhantejani alykhantejani mentioned this issue Sep 8, 2017
Merged
@alykhantejani
Copy link
Contributor

Hi @chasezheng,

I've submitted a PR with the doc change, although note retain_variables is not in the docstring as it has been deprecated and you should use retain_graph instead. See here for deprecation warning.

@soumith soumith closed this as completed Sep 9, 2017
@houseroad houseroad mentioned this issue May 10, 2020
Closed
houseroad added a commit to houseroad/pytorch that referenced this issue May 26, 2020
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to 20b3e10e6c3a9cdab90d2bb864d1c36d3e…
b56b756 
…3651cd (pytorch#38203)

Summary:
Pull Request resolved: pytorch#38203

Previous import was 79a7e0df7e86e0f32e7a05f563b24a566540c18b

Included changes:
- **[20b3e10e](onnx/onnx@20b3e10e)**: Add 'ignore_index' input in the spec for SoftmaxCrossEntropyLoss and NLLLoss. (pytorch#2680) <M. Zeeshan Siddiqui>
- **[eae3eb8c](onnx/onnx@eae3eb8c)**: Use cmake GNUInstallDirs (pytorch#2661) <Gustavo Alvarez>
- **[106821e9](onnx/onnx@106821e9)**: Update sequence test case so input is not scalar and splits are specified (pytorch#2675) <Scott McKay>
- **[e094e101](onnx/onnx@e094e101)**: Remove unnecessary copies and std::move (pytorch#2684) <Changming Sun>
- **[71145275](onnx/onnx@71145275)**: Update Batchnorm test (pytorch#2674) <Lara Haidar>
- **[da13be2d](onnx/onnx@da13be2d)**: Rename OPTIONAL to OPTIONAL_VALUE (pytorch#2682) <Changming Sun>
- **[2987fa06](onnx/onnx@2987fa06)**: Adding CI for ONNX Debug mode (Linux, OSX) (pytorch#2651) <Vinitra Swamy>
- **[46fe392d](onnx/onnx@46fe392d)**: Update Pow input types in Opset 12 (pytorch#2666) <Lara Haidar>
- **[ac1caf3b](onnx/onnx@ac1caf3b)**: Change type of label tensor to int32/int64 in SoftmaxCrossEntropyLoss spec. (pytorch#2667) <M. Zeeshan Siddiqui>
- **[c2fefcbf](onnx/onnx@c2fefcbf)**: [Training] SG with Momentum Optimizer (pytorch#1959) <Wei-Sheng Chin>
- **[8d15705e](onnx/onnx@8d15705e)**: [Training] Add Adagrad optimizer operator (pytorch#1955) <Wei-Sheng Chin>
- **[94b01cdd](onnx/onnx@94b01cdd)**: Suppress a warning in unsqueeze (pytorch#2637) <Hong Xu>
- **[0582d526](onnx/onnx@0582d526)**: Fix Greater/LessOrEqual function definition (pytorch#2645) <Takeshi Watanabe>
- **[b852d819](onnx/onnx@b852d819)**: Increment version number to 1.7.0 (pytorch#2639) <Chin Huang>
- **[ff4bb553](onnx/onnx@ff4bb553)**: Regenerate Min test data (pytorch#2644) <Takeshi Watanabe>

Test Plan: ci

Reviewed By: hl475

Differential Revision: D21493165

fbshipit-source-id: c5eb2f0143f1763166f46f118ec0985b41f759b3
facebook-github-bot pushed a commit that referenced this issue May 27, 2020
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to 20b3e10e6c3a9cdab90d2bb864d1c36d3e…
51274b5 
…3651cd (#38203)

Summary:
Pull Request resolved: #38203

Previous import was 79a7e0df7e86e0f32e7a05f563b24a566540c18b

Included changes:
- **[20b3e10e](onnx/onnx@20b3e10e)**: Add 'ignore_index' input in the spec for SoftmaxCrossEntropyLoss and NLLLoss. (#2680) <M. Zeeshan Siddiqui>
- **[eae3eb8c](onnx/onnx@eae3eb8c)**: Use cmake GNUInstallDirs (#2661) <Gustavo Alvarez>
- **[106821e9](onnx/onnx@106821e9)**: Update sequence test case so input is not scalar and splits are specified (#2675) <Scott McKay>
- **[e094e101](onnx/onnx@e094e101)**: Remove unnecessary copies and std::move (#2684) <Changming Sun>
- **[71145275](onnx/onnx@71145275)**: Update Batchnorm test (#2674) <Lara Haidar>
- **[da13be2d](onnx/onnx@da13be2d)**: Rename OPTIONAL to OPTIONAL_VALUE (#2682) <Changming Sun>
- **[2987fa06](onnx/onnx@2987fa06)**: Adding CI for ONNX Debug mode (Linux, OSX) (#2651) <Vinitra Swamy>
- **[46fe392d](onnx/onnx@46fe392d)**: Update Pow input types in Opset 12 (#2666) <Lara Haidar>
- **[ac1caf3b](onnx/onnx@ac1caf3b)**: Change type of label tensor to int32/int64 in SoftmaxCrossEntropyLoss spec. (#2667) <M. Zeeshan Siddiqui>
- **[c2fefcbf](onnx/onnx@c2fefcbf)**: [Training] SG with Momentum Optimizer (#1959) <Wei-Sheng Chin>
- **[8d15705e](onnx/onnx@8d15705e)**: [Training] Add Adagrad optimizer operator (#1955) <Wei-Sheng Chin>
- **[94b01cdd](onnx/onnx@94b01cdd)**: Suppress a warning in unsqueeze (#2637) <Hong Xu>
- **[0582d526](onnx/onnx@0582d526)**: Fix Greater/LessOrEqual function definition (#2645) <Takeshi Watanabe>
- **[b852d819](onnx/onnx@b852d819)**: Increment version number to 1.7.0 (#2639) <Chin Huang>
- **[ff4bb553](onnx/onnx@ff4bb553)**: Regenerate Min test data (#2644) <Takeshi Watanabe>

Test Plan: ci

Reviewed By: hl475

Differential Revision: D21493165

fbshipit-source-id: 6863b289bfbf4235e36f0e2456ce44c776aaf164
houseroad added a commit to houseroad/pytorch that referenced this issue May 27, 2020
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to eae3eb8c61cf5ad27cc9a416dbdc527498…
0ef2a34 
…2385a6

Summary:
Previous import was 79a7e0df7e86e0f32e7a05f563b24a566540c18b

Included changes:
- **[eae3eb8c](onnx/onnx@eae3eb8c)**: Use cmake GNUInstallDirs (pytorch#2661) <Gustavo Alvarez>
- **[106821e9](onnx/onnx@106821e9)**: Update sequence test case so input is not scalar and splits are specified (pytorch#2675) <Scott McKay>
- **[e094e101](onnx/onnx@e094e101)**: Remove unnecessary copies and std::move (pytorch#2684) <Changming Sun>
- **[71145275](onnx/onnx@71145275)**: Update Batchnorm test (pytorch#2674) <Lara Haidar>
- **[da13be2d](onnx/onnx@da13be2d)**: Rename OPTIONAL to OPTIONAL_VALUE (pytorch#2682) <Changming Sun>
- **[2987fa06](onnx/onnx@2987fa06)**: Adding CI for ONNX Debug mode (Linux, OSX) (pytorch#2651) <Vinitra Swamy>
- **[46fe392d](onnx/onnx@46fe392d)**: Update Pow input types in Opset 12 (pytorch#2666) <Lara Haidar>
- **[ac1caf3b](onnx/onnx@ac1caf3b)**: Change type of label tensor to int32/int64 in SoftmaxCrossEntropyLoss spec. (pytorch#2667) <M. Zeeshan Siddiqui>
- **[c2fefcbf](onnx/onnx@c2fefcbf)**: [Training] SG with Momentum Optimizer (pytorch#1959) <Wei-Sheng Chin>
- **[8d15705e](onnx/onnx@8d15705e)**: [Training] Add Adagrad optimizer operator (pytorch#1955) <Wei-Sheng Chin>
- **[94b01cdd](onnx/onnx@94b01cdd)**: Suppress a warning in unsqueeze (pytorch#2637) <Hong Xu>
- **[0582d526](onnx/onnx@0582d526)**: Fix Greater/LessOrEqual function definition (pytorch#2645) <Takeshi Watanabe>
- **[b852d819](onnx/onnx@b852d819)**: Increment version number to 1.7.0 (pytorch#2639) <Chin Huang>
- **[ff4bb553](onnx/onnx@ff4bb553)**: Regenerate Min test data (pytorch#2644) <Takeshi Watanabe>

Test Plan: ci

Differential Revision: D21750299

fbshipit-source-id: ba52d96806b70fd4ff56a9743b5e56879ecf2b88
@houseroad houseroad mentioned this issue May 27, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue May 28, 2020
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to eae3eb8c61cf5ad27cc9a416dbdc527498…
90a8cdf 
…2385a6 (#39089)

Summary:
Pull Request resolved: #39089

Previous import was 79a7e0df7e86e0f32e7a05f563b24a566540c18b

Included changes:
- **[eae3eb8c](onnx/onnx@eae3eb8c)**: Use cmake GNUInstallDirs (#2661) <Gustavo Alvarez>
- **[106821e9](onnx/onnx@106821e9)**: Update sequence test case so input is not scalar and splits are specified (#2675) <Scott McKay>
- **[e094e101](onnx/onnx@e094e101)**: Remove unnecessary copies and std::move (#2684) <Changming Sun>
- **[71145275](onnx/onnx@71145275)**: Update Batchnorm test (#2674) <Lara Haidar>
- **[da13be2d](onnx/onnx@da13be2d)**: Rename OPTIONAL to OPTIONAL_VALUE (#2682) <Changming Sun>
- **[2987fa06](onnx/onnx@2987fa06)**: Adding CI for ONNX Debug mode (Linux, OSX) (#2651) <Vinitra Swamy>
- **[46fe392d](onnx/onnx@46fe392d)**: Update Pow input types in Opset 12 (#2666) <Lara Haidar>
- **[ac1caf3b](onnx/onnx@ac1caf3b)**: Change type of label tensor to int32/int64 in SoftmaxCrossEntropyLoss spec. (#2667) <M. Zeeshan Siddiqui>
- **[c2fefcbf](onnx/onnx@c2fefcbf)**: [Training] SG with Momentum Optimizer (#1959) <Wei-Sheng Chin>
- **[8d15705e](onnx/onnx@8d15705e)**: [Training] Add Adagrad optimizer operator (#1955) <Wei-Sheng Chin>
- **[94b01cdd](onnx/onnx@94b01cdd)**: Suppress a warning in unsqueeze (#2637) <Hong Xu>
- **[0582d526](onnx/onnx@0582d526)**: Fix Greater/LessOrEqual function definition (#2645) <Takeshi Watanabe>
- **[b852d819](onnx/onnx@b852d819)**: Increment version number to 1.7.0 (#2639) <Chin Huang>
- **[ff4bb553](onnx/onnx@ff4bb553)**: Regenerate Min test data (#2644) <Takeshi Watanabe>

Test Plan: ci

Reviewed By: hl475

Differential Revision: D21750299

fbshipit-source-id: c33ec1b1e0dc65d0187e78db96d749f9037aae9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alykhantejani @soumith @chasezheng
0