8000 [release/1.9] Fix issues regarding binary_chekcout by seemethere · Pull Request #58495 · pytorch/pytorch · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release/1.9] Fix issues regarding binary_chekcout #58495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2021
Merged

[release/1.9] Fix issues regarding binary_chekcout #58495

merged 1 commit into from
May 18, 2021

Conversation

seemethere
Copy link
Member
@seemethere seemethere commented May 18, 2021 •
edited
Loading

Fixes issues where things included in the BASH_ENV were not properly getting set due to lacking quotes around variables.

See: https://app.circleci.com/pipelines/github/pytorch/pytorch/323635/workflows/7759eb83-70b8-403e-9e4f-258034999335/jobs/13536054

@seemethere
add quotes around env file setup
06960d7 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented May 18, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 06960d7 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@seemethere seemethere changed the title ci: Release branch specific changes [release/1.9] Fix issues regarding binary_chekcout May 18, 2021
@seemethere seemethere added this to the 1.9.0 milestone May 18, 2021
@seemethere seemethere requested a review from a team May 18, 2021 17:35
@seemethere seemethere merged commit 085a3bc into release/1.9 May 18, 2021
@seemethere seemethere deleted the fix_binary_checkout branch May 18, 2021 17:36
malfet pushed a commit to malfet/pytorch that referenced this pull request May 19, 2021
@seemethere @malfet
Fix issues regarding binary_checkout
b9a0980 
Cherry-pick of pytorch#58495 back to master

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@malfet malfet mentioned this pull request May 19, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request May 19, 2021
@seemethere @facebook-github-bot
Fix issues regarding binary_checkout (#58558)
4cf9b11 
Summary:
Cherry-pick of #58495 back to master

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Fixes #58557

Pull Request resolved: #58558

Reviewed By: albanD

Differential Revision: D28538867

Pulled By: malfet

fbshipit-source-id: 3517d8729df7c0c0a221d26f6966c8dcef2f3076
Lilyjjo added a commit that referenced this pull request May 19, 2021
@Lilyjjo
[release/1.9] Fix issues regarding binary_chekcout (#58495)
898786c 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
This was referenced May 19, 2021
Closed
Closed
Closed
Closed
Lilyjjo added a commit that referenced this pull request May 19, 2021
@Lilyjjo
[release/1.9] Fix issues regarding binary_chekcout (#58495)
45b4eac 
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samestep samestep samestep approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seemethere @facebook-github-bot @samestep
0