8000 Get test_configs.py working · Issue #466 · pytorch/torchtune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get test_configs.py working #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ebsmothers opened this issue Mar 7, 2024 · 1 comment
Closed

Get test_configs.py working #466

ebsmothers opened this issue Mar 7, 2024 · 1 comment
Assignees
@RdoubleA

Comments

@ebsmothers
Copy link
Contributor

Our configs test is currently being skipped after changes in #406. After our packaging changes (#445), it contains invalid imports. As part of #460 this file is being deleted.

Creating this issue so that we write a new config test without using illegal imports from recipes/.
@ebsmothers ebsmothers mentioned this issue Mar 7, 2024
Merged
@RdoubleA RdoubleA mentioned this issue Mar 8, 2024
Merged
@ebsmothers
Copy link
Contributor Author

Closing as this has been addressed

yinfan98 pushed a commit to yinfan98/sgl-tune-eagle that referenced this issue May 26, 2025
@vkuzo
clean up float8 configs in torchtitan (pytorch#466)
69fe8de 
Summary:

1. standardizes on `float8` instead of `fp8` for config names
2. removes usage of non-public objects such as `Float8Linear`

Test Plan:

```
with-proxy NGPU=1 CUDA_VISIBLE_DEVICES=7 CONFIG_FILE="./train_configs/debug_model.toml" ./run_llama_train.sh --training.compile --training.enable_float8_linear
```

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RdoubleA RdoubleA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebsmothers @RdoubleA
0