8000 [Eazy][Fix] Update the lora recipes configs model checkpoint path by SLR722 · Pull Request #499 · pytorch/torchtune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Eazy][Fix] Update the lora recipes configs model checkpoint path #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Eazy][Fix] Update the lora recipes configs model checkpoint path #499

wants to merge 1 commit into from

Conversation

SLR722
Copy link
Contributor
@SLR722 SLR722 commented Mar 14, 2024

Context

Changelog

  • Update the paths to make it easier for user to kick off training

Test plan

  • tune --nnodes 1 --nproc_per_node 1 lora_finetune_single_device --config alpaca_llama2_lora_finetune_single_device
  • tune --nnodes 1 --nproc_per_node 1 lora_finetune_distributed --config alpaca_llama2_lora_finetune_distributed and kick off training successfully

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2024
@netlify Netlify
Copy link
netlify bot commented Mar 14, 2024 •
edited
Loading

✅ Deploy Preview for torchtune-preview ready!

Name Link
🔨 Latest commit 360694c
🔍 Latest deploy log https://app.netlify.com/sites/torchtune-preview/deploys/65f2a4e612c0a60008f32d7f
😎 Deploy Preview https://deploy-preview-499--torchtune-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kartikayk
kartikayk reviewed Mar 14, 2024
View reviewed changes
recipes/configs/alpaca_llama2_lora_finetune_single_device.yaml
@@ -12,7 +12,7 @@ model:
lora_rank: 8
lora_alpha: 16

model_checkpoint: /tmp/llama2_native
model_checkpoint: /tmp/llama2/llama2_native.pt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will conflict with #494. I'm in the process of merging this PR (waiting for CI tests to complete). So you'll need to rebase this.

@kartikayk
Copy link
Contributor

@SLR722 is this still needed? If not, maybe close?

@SLR722
Copy link
Contributor Author
SLR722 commented Mar 18, 2024

@SLR722 is this still needed? If not, maybe close?

Thanks for reminding! Just closed.

@SLR722 SLR722 closed this Mar 18, 2024
@SLR722 SLR722 deleted the uodate_lora_config_ckt_path branch April 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikayk kartikayk kartikayk left review comments

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@RdoubleA RdoubleA Awaiting requested review from RdoubleA

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SLR722 @kartikayk @facebook-github-bot
0