8000 Remove tests from package by joecummings · Pull Request #516 · pytorch/torchtune · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove tests from package #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 18, 2024
Merged

Remove tests from package #516

merged 18 commits into from
Mar 18, 2024

Conversation

joecummings
Copy link
Contributor
@joecummings joecummings commented Mar 18, 2024

Same as #453 but had a bad rebase before when testing.

Closes #394

Copy link
pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/516

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 65dccc7 with merge base e164402 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
Copy link
netlify bot commented Mar 18, 2024

Deploy Preview for torchtune-preview ready!

Name Link
🔨 Latest commit 65dccc7
🔍 Latest deploy log https://app.netlify.com/sites/torchtune-preview/deploys/65f89b3a6151a40008f68355
😎 Deploy Preview https://deploy-preview-516--torchtune-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joecummings joecummings requested a review from ebsmothers March 18, 2024 20:09
@joecummings joecummings merged commit b53d308 into main Mar 18, 2024
@joecummings joecummings deleted the remove-tests-from-package branch March 18, 2024 20:45
yinfan98 pushed a commit to yinfan98/sgl-tune-eagle that referenced this pull request May 26, 2025
…ch#516)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#473
* pytorch#517
* __->__ pytorch#516

Allows PP to be used without a seed checkpoint by calling `init_weight`
on each model part. This is the solution in step 1 of
pytorch/torchtitan#514 proposed by @wconstab
yinfan98 pushed a commit to yinfan98/sgl-tune-eagle that referenced this pull request May 26, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#473
* __->__ pytorch#517
* pytorch#516

Ran `pre-commit run --all-files`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py needs an overhaul (urgently)
3 participants
0