Support MCH for semi-sync #2753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
1a11db3 to
184b4b0
Compare
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Feb 27, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Feb 27, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
184b4b0 to
fda9b2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: pytorch#2753 ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
fda9b2f to
8ff9233
Compare
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Feb 27, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
8ff9233 to
7b18e03
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Mar 3, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: pytorch#2753 ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Differential Revision: D69861054
2ee0e83 to
debdac9
Compare
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Mar 3, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Reviewed By: dstaay-fb Differential Revision: D69861054
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Mar 3, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Reviewed By: dstaay-fb Differential Revision: D69861054
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Mar 3, 2025
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Reviewed By: dstaay-fb Differential Revision: D69861054
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
Summary: Pull Request resolved: pytorch#2753 ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this. Reviewed By: dstaay-fb Differential Revision: D69861054
|
This pull request was exported from Phabricator. Differential Revision: D69861054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: ZCH modules return a tuple of awaitables for embeddings and remapped KJTs. Update semi-sync training code to account for this
Differential Revision: D69861054