Set ruff target-version to the minimum supported version of Python
#1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore warning about adding import for future annotations. I tried it but it wreaked havoc due to how cmd2 actively validates type hints using inspect. If you use future annotations it delays evaluation until necessary, which benefits runtime performance but converts all type annotations to strings instead of types. Also, cleaned up how we specify ruff per-file ignores.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1441 +/- ##
==========================================
- Coverage 98.56% 98.55% -0.02%
==========================================
Files 20 20
Lines 5726 5726
==========================================
- Hits 5644 5643 -1
- Misses 82 83 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ruff
target-versionto the minimum supported version of Python, in our current casepy39.Ignore ruff
FA100warning about adding import for future annotations. I tried it but it wreaked havoc due to how cmd2 actively validates type hints using inspect. If you use future annotations it delays evaluation until necessary, which benefits runtime performance but converts all type annotations to strings instead of types.Also: