Fix parsing of new TR API event style and a few minor things #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional event types Remove duplicate doc ids in filenames
This was referenced May 31, 2025
nagy
reviewed
May 31, 2025
|
Tested it and indeed it works nicely for me. Thanks a lot! |
pytr/event.py
Outdated
| "ORDER_CANCELED", | ||
| "ORDER_CREATED", | ||
| "ORDER_EXPIRED", | ||
| "ORDER_REJECTED", | ||
| "PAYMENT-SERVICE-IN-PAYMENT-DIRECT-DEBIT", |
There was a problem hiding this comment.
This caused some direct transfers to be missing from the generated file for me...
There was a problem hiding this comment.
Hm, ok, removed for now. However, what kind of event is this? It is not mapped to anything through tr_event_type_mapping...
Maybe you could provide anonymised json data for this?
nagy
pushed a commit
to nagy/pytr
that referenced
this pull request
Jun 19, 2025
…g#223) Fix parsing of new event style Add additional event types Remove duplicate doc ids in filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trade Republic has modified the payload for some events. This needs some fixes in event parsing.
With this change I also add some event types that went unrecognized so far and I incorporate a suggestion about file names from #212.