Remove the "old" graph mode #264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjerning
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
-
Grepping for
new.*graphstill hits one match inpytrainer/core/activity.py, it's just a comment but a good opportunity to get rid of.
pytrainer/pytrainer/core/activity.py
Line 594 in fb6debc
-
Bringing up the recordgraph now generates a lot of GTK warnings that wasn't there before:
(pytrainer:871586): Gtk-WARNING **: 10:54:04.630: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.630: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.630: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.630: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.630: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.630: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-WARNING **: 10:54:04.664: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.664: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.664: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.664: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.664: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.664: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-WARNING **: 10:54:04.692: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.692: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.692: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.692: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.692: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.692: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-WARNING **: 10:54:04.720: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.720: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.720: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.720: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.721: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.721: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-WARNING **: 10:54:04.749: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.749: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.749: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.749: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.749: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.749: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-WARNING **: 10:54:04.776: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-WARNING **: 10:54:04.776: Attempting to add a widget with type GtkTable to a container of type GtkFrame, but the widget is already inside a container of type GtkFrame, please remove the widget from its existing container first.
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.776: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.776: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.776: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
(pytrainer:871586): Gtk-CRITICAL **: 10:54:04.776: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed
Comment on lines
-557
to
+554
| self.hbox30.show() | ||
| #Hide new graph details | ||
| self.graph_data_hbox.hide() | ||
| self.hboxGraphOptions.hide() | ||
| #Enable graph | ||
| self.record_vbox.set_sensitive(1) | ||
| self.drawarearecord.drawgraph(self.record_list,self.laps) | ||
| #Hide current drop down boxes | ||
| self.hbox30.hide() |
There was a problem hiding this comment.
I think hbox30 can be removed entirely, from what I understand it's the old graph mode.
Since hbox30 is still present in glade and toggled to show further down for activities without GPX data the two dropdowns with "Versus" in between can be seen for such activities.
Both these lines should then be removed too:
pytrainer/pytrainer/gui/windowmain.py
Lines 749 to 750 in fb6debc
This hasn't worked in years, so no point in carrying the option and code.
fb6debc to
8cd0cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't worked in years, so no point in carrying the option and code.