8000 Add a tool for DDD inspection. #542 by nbassler · Pull Request #543 · pytrip/pytrip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a tool for DDD inspection. #542 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a tool for DDD inspection. #542 #543

wants to merge 4 commits into from

Conversation

nbassler
Copy link
Member
@nbassler nbassler commented Sep 14, 2020 •
edited
Loading

closes #542

@nbassler nbassler added this to the 2.5.4 milestone Sep 14, 2020
@nbassler nbassler requested a review from grzanka September 14, 2020 11:43
@nbassler nbassler added the ready label Sep 14, 2020
grzanka
grzanka reviewed Sep 15, 2020
View reviewed changes
@grzanka
Copy link
Contributor
grzanka commented Sep 15, 2020

Can you add entry in entry_points in setup.py ?
https://github.com/pytrip/pytrip/blob/master/setup.py#L173

grzanka
grzanka requested changes Sep 15, 2020
View reviewed changes
pytrip/utils/dddplot.py
# add suffix
outfile = self.filename + "." + type

fig, (p1, p2) = plt.subplots(2, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of setting bigger filesize ? I.e. (15,10) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean a figsize, not filesize, i.e: fig, ax = plt.subplots(2,1, figsize=(20,10))

@nbassler
Copy link
Member Author

Can you add entry in entry_points in setup.py ?
https://github.com/pytrip/pytrip/blob/master/setup.py#L173

done

This was referenced Sep 16, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzanka grzanka grzanka requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.

add a simple DDD inspection plotter to utils/
2 participants
@nbassler @grzanka
0