8000 Fix ACSPO reader using binary operations on signed integers by djhoese · Pull Request #3125 · pytroll/satpy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix ACSPO reader using binary operations on signed integers #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your accou 8000 nt

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ACSPO reader using binary operations on signed integers #3125

wants to merge 1 commit into from

Conversation

djhoese
Copy link
Member
@djhoese djhoese commented May 12, 2025

Fix bug in the ACSPO reader where newer versions of xarray raise an exception if you try to do a bitwise operation on a signed integer. Not sure why but the ACSPO "l2p_flags" variable is a signed integer instead of an unsigned integer even though it is a bit mask.

This PR fixes the tests (which failed) to represent the data in real files and then fixes the bug by casting the flags to the unsigned version of their signed type.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this May 12, 2025
@djhoese djhoese requested a review from mraspaud as a code owner May 12, 2025 20:46
@codecov Codecov
Copy link
codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (78e88c4) to head (dc6987c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
- Coverage   96.23%   96.22%   -0.02%     
==========================================
  Files         398      398              
  Lines       57325    57330       +5     
==========================================
- Hits        55168    55165       -3     
- Misses       2157     2165       +8
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.01%) ⬇️
unittests 96.31% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14982274571

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.326%
Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 14862404225: -0.01%
Covered Lines: 55425
Relevant Lines: 57539
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud Awaiting requested review from mraspaud mraspaud is a code owner

Assignees

@djhoese djhoese

Labels
bug component:readers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djhoese @coveralls
0