8000 add METOP C coefficients by distein · Pull Request #86 · pytroll/pygac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add METOP C coefficients #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 17, 2020
Merged

add METOP C coefficients #86

merged 8 commits into from
Nov 17, 2020

Conversation

distein
Copy link
Contributor
@distein distein commented Oct 26, 2020 •
edited by sfinkens
Loading

Add provisional metop-c calibration coefficients as received via e-mail from Mike F. (20200922)

sfinkens
sfinkens approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member
@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @distein!

@sfinkens
Copy link
Member

Oh, the cecksum of the coefficient file has to be updated as well, right @carloshorn ?

@carloshorn
Copy link
Collaborator

Hi @distein,

Thanks for providing these coefficients. Sorry for the late reply, I was on vacation the last two weeks.

Oh, the checksum of the coefficient file has to be updated as well, right @carloshorn ?

Correct! We should add a test for the checksum, so we never forget to update it in the future.

@sfinkens
Copy link
Member
sfinkens commented Nov 2, 2020 •
edited
Loading

@carloshorn One test is already checking that: https://github.com/pytroll/pygac/blob/master/pygac/tests/test_calibration_coefficients.py#L178 . It fails if the coefs are not recognized.

@carloshorn
Copy link
Collaborator

One test is already checking that: [...]

Good, then I am fine with all the changes.

@ghost
Copy link
ghost commented Nov 17, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 21.092 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@sfinkens
Copy link
Member

As proposed by @mraspaud I added a status key to the coefficient dictionary which can be used to issue warnings if non-nominal coefficients are used.

@mraspaud
Copy link
Member
mraspaud commented Nov 17, 2020 •
edited
Loading

Looks good now! :)

mraspaud
mraspaud approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member
@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice touch with the enum!

@mraspaud
Copy link
Member

Feel free to merge

@sfinkens sfinkens merged commit 28a97a4 into pytroll:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@sfinkens sfinkens sfinkens approved these changes

@carloshorn carloshorn carloshorn approved these changes

Assignees

@distein distein

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@distein @sfinkens @carloshorn @mraspaud
0