Use the geotiepoints library #34
Conversation
There was a problem hiding this comment.
Thank you for the prompt PR ! Did you have some data to try out the changes ?
Regarding the geotiepoints part, my only concern is that there is some code duplication that could be factorized. Maybe the Gac_Lat_Lon_Interpolator function could be kept but made to use the geotiepoint lib. (And the name of that function would need to be sanitized)
Regarding the config file handling, I agree that some action needs to be taken, but I think it deserves some more discussion first and should be dealt with in another PR. So for now, could you just revert the changes in gac_io.py and maybe open an issue so that we can discuss the best course of action ?
pygac/gac_klm.py
Outdated
| cols_subset = np.arange(4, 405, 8) | ||
| cols_full = np.arange(409) | ||
| lines = arr_lat.shape[0] | ||
| rows_subset = np.arange(lines) | ||
| rows_full = np.arange(lines) | ||
| along_track_order = 1 | ||
| cross_track_order = 3 | ||
| satint = gtp.SatelliteInterpolator((arr_lon, arr_lat), | ||
| (rows_subset, cols_subset), | ||
| (rows_full, cols_full), | ||
| along_track_order, | ||
| cross_track_order) | ||
| self.lons, self.lats = satint.interpolate() | ||
| return self.lons, self.lats |
There was a problem hiding this comment.
Could you make a function for that ? It's being used in 2 places
There was a problem hiding this comment.
I limited the changes and kept the Gac Lat_Lon Interpolator function.I just made it work with Python Geotiepoints. Could you please take a look?! I test it with test code and everything is fine!
setup.py
Outdated
| # extras_require={'geolocation interpolation': ['python-geotiepoints'], | ||
| # }, |
There was a problem hiding this comment.
You don't need to keep this as a comment, just remove it.
|
@sfinkens would you like to test this ? |
|
Thanks for the contribution ! |
You're welcome! |
I added Python-geotiepoints in requirments list and looked after Chenges in gac_klm and gac_pod and finally removed geotiepoints.py.