10000 Implement open timeout for hislip by MatthieuDartiailh · Pull Request #430 · pyvisa/pyvisa-py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement open timeout for hislip #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 29, 2024
Merged

Implement open timeout for hislip #430

merged 17 commits into from
Dec 29, 2024

Conversation

MatthieuDartiailh
Copy link
Member

No description provided.

@MatthieuDartiailh MatthieuDartiailh mentioned this pull request May 27, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.25000% with 59 lines in your changes missing coverage. Please review.

Project coverage is 24.41%. Comparing base (8b47818) to head (5842b03).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyvisa_py/tcpip.py 12.50% 14 Missing ⚠️
pyvisa_py/protocols/rpc.py 7.14% 13 Missing ⚠️
pyvisa_py/gpib.py 20.00% 8 Missing ⚠️
pyvisa_py/highlevel.py 38.46% 8 Missing ⚠️
pyvisa_py/protocols/hislip.py 0.00% 6 Missing ⚠️
pyvisa_py/sessions.py 40.00% 6 Missing ⚠️
pyvisa_py/serial.py 50.00% 2 Missing ⚠️
pyvisa_py/usb.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   24.42%   24.41%   -0.02%     
==========================================
  Files          23       23              
  Lines        3492     3514      +22     
  Branches      400      401       +1     
==========================================
+ Hits          853      858       +5     
- Misses       2634     2651      +17     
  Partials        5        5
Flag Coverage Δ
unittests 24.41% <26.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthieuDartiailh MatthieuDartiailh force-pushed the hislip-connect-timeout branch 2 times, most recently from db8f22b to 7959ea5 Compare September 17, 2024 17:25
MatthieuDartiailh and others added 16 commits December 17, 2024 13:18
@MatthieuDartiailh
tcpip: implement open timeout for hislip
85a013a
@MatthieuDartiailh
tcpip: fix typing
718cd75
@MatthieuDartiailh
testsuite: add debug prints
2c5829b
@MatthieuDartiailh
fix issue on 3.9 and add a changelog entry
4ac2711
@MatthieuDartiailh
fix linting issues
c56962c
@pre-commit-ci @MatthieuDartiailh
[pre-commit.ci] pre-commit autoupdate (#440)
5f10f09 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.1](astral-sh/ruff-pre-commit@v0.5.0...v0.5.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@MatthieuDartiailh
fix issue on 3.9 and add a changelog entry
6042c08
@MatthieuDartiailh
sessions: improve handling of open connection error for TCPIP resources
e3d05f6
@MatthieuDartiailh
ci and linter fixes
3011546
@MatthieuDartiailh
linter fixes
77f1c32
@MatthieuDartiailh
use the right logger in tcpip sessions
a4a10de
@MatthieuDartiailh
hislip: respect the VISA spec and do not use open_timeout for socket…
51afa35 
… connection
@MatthieuDartiailh
hislip: respect the VISA spec and do not use open_timeout for socket …
16aac06 
…connection
@MatthieuDartiailh
tcpip: allow more exception to cause a failure to open a connection
c5afc7f
@MatthieuDartiailh
highlevel: handle return code when connection opening fails
0afe36c
@MatthieuDartiailh
consistently use the logger adapter signaling the message originate f…
a76d3fb 
…rom the py backend
@MatthieuDartiailh MatthieuDartiailh merged commit b4693f6 into main Dec 29, 2024
18 of 19 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the hislip-connect-timeout branch December 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MatthieuDartiailh
0