-
Notifications
You must be signed in to change notification settings - Fork 66
Introduce packaging #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add MIT license
- use setuptools-scm
- add Makefile target for image and pypi-checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done, just a few notes
LICENSE
Outdated
@@ -0,0 +1,21 @@ | |||
MIT License | |||
|
|||
Copyright (c) 2018 Userspace Containerization team at Red Hat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just red hat, we are not a separate enitity :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've copied that from source-git -- we need to change that also there.
There was a proble 10000 m hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably in multiple repos...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
recipe.yaml
Outdated
- twine # we need newest twine, b/c of the check command | ||
- readme_renderer[md] | ||
state: latest | ||
- name: Install dependencies for CI watcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we won't need this task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed that. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need most of the packages, so I've changed that only a bit.
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
bfeb713
to
640bbf3
Compare
I've fixed the issues from the review. |
merge main repo in