8000 Introduce packaging by lachmanfrantisek · Pull Request #3 · packit/ogr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introduce packaging #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

lachmanfrantisek
Copy link
Member
  • add MIT license
  • use setuptools-scm
  • add Makefile target for image and pypi-checking

Copy link
Member
@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, just a few notes

LICENSE Outdated
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2018 Userspace Containerization team at Red Hat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just red hat, we are not a separate enitity :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied that from source-git -- we need to change that also there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably in multiple repos...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

recipe.yaml Outdated
- twine # we need newest twine, b/c of the check command
- readme_renderer[md]
state: latest
- name: Install dependencies for CI watcher
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't need this task

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed that. Thanks.

Copy link
Member Author
@lachmanfrantisek lachmanfrantisek Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we need most of the packages, so I've changed that only a bit.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek
Copy link
Member Author

I've fixed the issues from the review.

@TomasTomecek TomasTomecek merged commit 29ca3ca into packit:master Jan 11, 2019
@lachmanfrantisek lachmanfrantisek deleted the packaging branch January 12, 2019 14:24
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0