Introduce packaging #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- add MIT license
- use setuptools-scm
- add Makefile target for image and pypi-checking
TomasTomecek
requested changes
Jan 11, 2019
LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018 Userspace Containerization team at Red Hat | |||
There was a problem hiding this comment.
just red hat, we are not a separate enitity :D
There was a problem hiding this comment.
I've copied that from source-git -- we need to change that also there.
There was a proble 10000 m hiding this comment.
It is probably in multiple repos...
recipe.yaml
Outdated
| - twine # we need newest twine, b/c of the check command | ||
| - readme_renderer[md] | ||
| state: latest | ||
| - name: Install dependencies for CI watcher |
There was a problem hiding this comment.
Oh, I missed that. Thanks.
There was a problem hiding this comment.
But we need most of the packages, so I've changed that only a bit.
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
bfeb713 to
640bbf3
Compare
|
I've fixed the issues from the review. |
TomasTomecek
approved these changes
Jan 11, 2019
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 5, 2019
merge main repo in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.