rename validate config to config validate for config grouping #2559
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 07s |
packit/cli/__init__.py
Outdated
|
|
||
| import click | ||
|
|
||
| from packit.cli.config import config # Import the new config group | ||
|
|
||
|
|
||
| @click.group() | ||
| def cli(): | ||
| pass | ||
|
|
||
|
|
||
| # Register the config group. | ||
| cli.add_command(config) | ||
|
|
||
| if __name__ == "__main__": | ||
| cli() |
There was a problem hiding this comment.
instead of this, the command should be added here
There was a problem hiding this comment.
ok @lbarcziova. Thanks for taking out time to review my code. will amend as requested
|
Build failed. ❌ pre-commit FAILURE in 2m 02s |
packit/cli/__init__.py
Outdated
|
|
||
| import click | ||
|
|
||
| from packit.cli.config import config # Import the new config group | ||
|
|
||
|
|
||
| @click.group() | ||
| def cli(): | ||
| pass | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| cli() |
There was a problem hiding this comment.
I would say this is not needed as we are initialising it here
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 06s |
packit/cli/__init__.py
Outdated
|
|
||
| from packit.cli.packit_base import packit_base | ||
|
|
||
| if __name__ == "__main__": | ||
| packit_base() |
There was a problem hiding this comment.
I think this file doesn't need any changes generally, because the initialisation happens already here
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 04s |
There was a problem hiding this comment.
LGTM, thanks!
Can you please squash the commits and rebase?
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 06s |
|
Hello @lbarcziova , a gentle reminder that i have squashed and rebased |
Signed-off-by: Olamidepeterojo <peterojoolamide@gmail.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
|
@olamidepeterojo sorry, I was out last week, going to merge this now. |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 09s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 05s |
a66cbcb
into
packit:main
The command was renamed from `validate-config` to `config validate` in packit/packit#2559
The command was renamed from `validate-config` to `config validate` in packit/packit#2559
Adjust validate-config occurences to the rename The command was renamed from validate-config to config validate in packit/packit#2559 Reviewed-by: Matej Focko
The command was renamed from `validate-config` to `config validate` in packit/packit#2559
The command was renamed from `validate-config` to `config validate` in packit/packit#2559
Adjust validate-config occurences to the rename The command was renamed from validate-config to config validate in packit/packit#2559 TODO: fix references (packit-service, ?) RELEASE NOTES BEGIN N/A RELEASE NOTES END Reviewed-by: František Lachman <flachman@redhat.com>
TODO:
packit/packit.dev.Fixes #2437
Related to
Merge before/after
RELEASE NOTES BEGIN
We have introduced a new command group
configfor configuration-related commands and movedvalidate-configcommand under it, resulting in the new command beingpackit config validate.RELEASE NOTES END