8000 detect program name with python -m by gmelodie · Pull Request #1609 · pallets/click · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

detect program name with python -m #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

detect program name with python -m #1609

merged 1 commit into from
Aug 6, 2020

Conversation

gmelodie
Copy link
Contributor

Fixes #1603

@davidism davidism force-pushed the program-name-detection branch from 425c0a4 to 3b8e526 Compare August 6, 2020 03:14
@davidism
< 8000 /svg> Copy link
Member
davidism commented Aug 6, 2020 •
edited
Loading

Rewrote the docstring, added changelog. Simplified the function a bit more, we only care about getting a representative value for the help text. (Werkzeug needed the exact executable and file paths.) Made the function private (_detect_program_name) for now since I don't really see it being useful as a public API. Simplified the test since it doesn't need to mock relpath, but used pathlib to get the proper path separators on Windows.

@davidism davidism force-pushed the program-name-detection branch from 3b8e526 to 7bfe2c2 Compare August 6, 2020 03:19
@davidism davidism added this to the 8.0.0 milestone Aug 6, 2020
@kbanc @gmelodie @davidism
detect program name when run with python -m
faaec82 
Co-authored-by: Gabriel de Melo Cruz <gabrieldemelocruz@gmail.com>
@davidism davidism force-pushed the program-name-detection branch from 7bfe2c2 to faaec82 Compare August 6, 2020 03:23
@davidism davidism changed the title Program name detection detect program name with python -m Aug 6, 2020
@davidism davidism merged commit 6c1eaba into pallets:master Aug 6, 2020
@davidism davidism deleted the program-name-detection branch August 6, 2020 03:27
@davidism davidism mentioned this pull request Aug 9, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

detection of program name when run with python -m
3 participants
@gmelodie @davidism @kbanc
0