8000 Small fixes by krajzeg · Pull Request #4 · palparepa/decker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Small fixes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Small fixes #4

wants to merge 2 commits into from

Conversation

krajzeg
Copy link
@krajzeg krajzeg commented Oct 17, 2020

Hey,

Two unrelated fixes in this PR (not the best practice, I know).

The important one is something I found while checking out the source code to learn how the game works - the "analyze level" of an ICE was not taken into account at all when determining its GetEffectiveRating(), due to a stray "this":

	if (this.bIncludeAnalyze)
		nRating -= this.m_nAnalyzed;

This makes analyze completely useless without the fix.

The other is a small fix for issue #1, enabling the scan button in COP nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krajzeg
0