8000 adding otp name defaults for microsoft and gitlab by casonadams · Pull Request #503 · passff/passff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

adding otp name defaults for microsoft and gitlab #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

casonadams
Copy link
@casonadams casonadams commented Dec 15, 2021

login.microsoftonline.com: otc
gitlab.com: user[otp_attempt]

@tuxor1337
Copy link
Collaborator

Actually, I don't want to come in the situation, where I have to add every single input name of every OTP provider out there to the list. However, it seems like gitlab and microsoft are among the major OTP services and there won't be too many of comparable relevance, right?

@casonadams
Copy link
Author

Hard to say. More and more services are going to MFA, but I do feel that Microsoft and Gitlab are large footprints that this would help cover. I'm not sure the best way to cover them all, I do like the flexibility the plugin provides, it would be nice if it could be a personal config file that I could keep under source control.

@casonadams
Copy link
Author

Should I close this MR out?

@tuxor1337
Copy link
Collaborator

No, it's cool. We will merge this for now, considering the relevance of those particular OTP providers. Still, your idea about a personal config file to keep under source control sounds much more elegant. For example, we could have a particular entry in your password store that is recognized as a PassFF config file. If you are still interested in such a feature feel free to start a conversation in a new GitHub issue, or directly propose your own implementation in a PR.

@tuxor1337 tuxor1337 merged commit 2a53aea into passff:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0