Tags: paralin/go-tools
Tags
gopls/internal/test/marker/testdata: skip hover size tests on 32-bit arm Fixes golang/go#66686 Change-Id: I74388fa8788ff6893146e3ca0cdfccfd28275625 Reviewed-on: https://go-review.googlesource.com/c/tools/+/576657 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Alan Donovan <adonovan@google.com>
go/packages: correctly handle context canceled If the context is canceled for packages.Load, the following log message is written numerous times to stderr and returned as a load error per-package: internal error: error "context canceled" (*errors.errorString) without position packages.Load now checks if the context was canceled while parsing files and returns nil, ctx.Err() if so. parseFiles now will not create unnecessary goroutines when ctx is canceled. ld.Config.Context is equivalent to ld.Context as Config is an embedded struct within loader. Use ld.Context to refer to ld.Config.Context for consistency.
go/packages: correctly handle context canceled If the context is canceled for packages.Load, the following log message is written numerous times to stderr and returned as a load error per-package: internal error: error "context canceled" (*errors.errorString) without position packages.Load now checks if the context was canceled while parsing files and returns nil, ctx.Err() if so. parseFiles now will not create unnecessary goroutines when ctx is canceled. ld.Config.Context is equivalent to ld.Context as Config is an embedded struct within loader. Use ld.Context to refer to ld.Config.Context for consistency.
go/packages: correctly handle context canceled If the context is canceled for packages.Load, the following log message is written numerous times to stderr and returned as a load error per-package: internal error: error "context canceled" (*errors.errorString) without position packages.Load now checks if the context was canceled while parsing files and returns nil, ctx.Err() if so. parseFiles now will not create unnecessary goroutines when ctx is canceled. ld.Config.Context is equivalent to ld.Context as Config is an embedded struct within loader. Use ld.Context to refer to ld.Config.Context for consistency.
go/packages: correctly handle context canceled If the context is canceled for packages.Load, the following log message is written numerous times to stderr and returned as a load error per-package: internal error: error "context canceled" (*errors.errorString) without position Check if the context was canceled and return nil, ctx.Err() instead. Use ld.Context which is ld.Config.Context if non-nil and otherwise defaults to context.Background to avoid nil references on ld.Config.Context. Signed-off-by: Christian Stewart <christian@aperture.us>
gopls: update go.mod for v0.15.2-pre.2 Update x/tools. For golang/go#66197 Change-Id: I7143d1a371a2eed88186cb0c5cf7019a78931b5e Reviewed-on: https://go-review.googlesource.com/c/tools/+/570756 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
gopls: update go.mod for v0.15.2-pre.2 Update x/tools. For golang/go#66197 Change-Id: I7143d1a371a2eed88186cb0c5cf7019a78931b5e Reviewed-on: https://go-review.googlesource.com/c/tools/+/570756 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
gopls: update go.mod for v0.15.2-pre.1 Update x/tools. For golang/go#66197 Change-Id: I9322ee52e4ed40fde3c6c597df2305c3dd2dfff3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/569881 Reviewed-by: Nooras Saba <saba@golang.org> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
cmd/guru: remove replace directive Updates golang/go#65880 Change-Id: Icb45d94bd2ef0864ab054e76a6aa651b269e2ec5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/570139 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Alan Donovan <adonovan@google.com>
gopls/internal/server: set -mod=readonly when checking for upgrades When a vendor directory is present, we must explicitly use -mod=readonly to query upgrades with `go list`. This was broken by the fixes for workspace vendoring, which removed the `-mod` flag in most usage of the gocommand package. Fixes golang/go#66055 Change-Id: I29efb617a8fe56e9752dc088dc5ea884f1cefb86 Reviewed-on: https://go-review.googlesource.com/c/tools/+/569877 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
PreviousNext