8000 updated main.go script to reinitialize the permissions when the are e… by swastik959 · Pull Request #366 · paralus/paralus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

updated main.go script to reinitialize the permissions when the are e… #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 20, 2025
Merged

updated main.go script to reinitialize the permissions when the are e… #366

merged 11 commits into from
Mar 20, 2025

Conversation

swastik959
Copy link
Contributor

…xisting or there is any update

What does this PR change?

  • updated main.go script to reinitialize the permissions when the are e…

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@swastik959
updated main.go script to reinitialize the permissions when the are e…
f9417d4 
…xisting or there is any update

Signed-off-by: swastik959 <Sswastik959@gmail.com>
niravparikh05
niravparikh05 requested changes Feb 3, 2025
View reviewed changes
@swastik959
added few corrections and added better error logging
1921dfb 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
added the checks for checking the existence of different components
3fe1d3d 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
started adding the Upsert function
cefc507 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
akshay196
akshay196 reviewed Feb 14, 2025
8000
View reviewed changes
Copy link
Member
@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swastik959
The use of Upsert is looking good. Keep updating the code and let us know when it's ready for review.

@swastik959
added upsert to role.go
18121ba 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
akshay196
akshay196 requested changes Feb 19, 2025
View reviewed changes
@swastik959
added tests and auditing
c69f067 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@akshay196
Copy link
Member

To fix Trivy scanner issues update following go packages:

  • golang.org/x/crypto frmo v0.21.0 to 0.31.0
  • golang.org/x/net from v0.23.0 to 0.33.0
  • go version from 1.21.13 to 1.23.1

@swastik959
updated packages
c6f88f1 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
updated go version
7af7eaf 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959 swastik959 requested a review from akshay196 March 11, 2025 05:40
@swastik959
added minor changes
03c2bca 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
added correction to role_test.go
a35bfdb 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
corrected test cases
d2b3237 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.79775% with 225 lines in your changes missing coverage. Please review.

Project coverage is 12.17%. Comparing base (9f8ce0c) to head (d2b3237).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
scripts/initialize/main.go 0.00% 166 Missing ⚠️
pkg/service/role.go 0.00% 47 Missing ⚠️
pkg/service/organization.go 88.15% 6 Missing and 3 partials ⚠️
pkg/service/partner.go 95.52% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #366       +/-   ##
===========================================
- Coverage   34.41%   12.17%   -22.24%     
===========================================
  Files          74      333      +259     
  Lines       11783    53537    +41754     
===========================================
+ Hits         4055     6518     +2463     
- Misses       7175    46307    +39132     
- Partials      553      712      +159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niravparikh05 niravparikh05 merged commit 7a4895a into paralus:main Mar 20, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay196 akshay196 akshay196 approved these changes

@niravparikh05 niravparikh05 niravparikh05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swastik959 @akshay196 @codecov-commenter @niravparikh05
0