Upgrade rocksdb to 0.23.0 #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Feb 17, 2025
niklasad1
approved these changes
Feb 17, 2025
bkchr
approved these changes
Feb 17, 2025
|
@jasl can you fix CI? looks like we will need to install some extra dependencies. |
No problem, I will do later |
411a69f to
d8d30c5
Compare
CI should fixed. FYI, I update |
|
Is it worth it to release a new version for kvdb-rocksdb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocksDB 0.23.0 was released on Dec 24, 2024.
Polkadot is still using 0.21.0, released on May 9, 2023. since it is still the default DB, I propose updating it to the new version. However, I don't know if we can gain performance improvement here.
I don't see it has a breaking change: https://github.com/rust-rocksdb/rust-rocksdb/releases/tag/v0.23.0