Rescue commented logging calls #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolcl
requested changes
Apr 5, 2025
There was a problem hiding this comment.
Thanks!
But this needs more work.
First, in CMakeLists.txt, we have CMAKE_BUILD_TYPE which may be DEBUG or RELEASE. When building the library, tests and example program in release mode, we should avoid debugging output.
Then, I suggest to initialize debugging also in the unit tests:
#include <fstream>
#include <libsonivox/eas.h>
#include <libsonivox/eas_report.h>
#include <libsonivox/eas_reverb.h>
#include "SonivoxTestEnvironment.h"
@@ -419,8 +420,10 @@ int main(int argc, char **argv) {
::testing::InitGoogleTest(&argc, argv);
int status = gEnv->initFromOptions(argc, argv);
if (status == 0) {
EAS_SetDebugFile(stderr, 1);
EAS_SetDebugLevel(_EAS_SEVERITY_NOFILTER);
status = RUN_ALL_TESTS();
ALOGV("Test result = %d\n", status);
EAS_Report(_EAS_SEVERITY_WARNING, "Test result = %d\n", status);
}
return status;
}Please consider also adjusting the severity level on some places.
pedrolcl
added a commit
that referenced
this pull request
Apr 12, 2025
After PR #45, users should be able to choose the verbosity level when running the rendering utility/example program. This commit adds a `-V | --Verbosity` option. If not provided the default severity is applied depending on the build settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rescue commented logging calls, and also added loggings for AOSP's sanity checks.
Now sonivoxrender prints logs to stderr.
Related Issues
Closes #43
Checklist