8000 Improve test dls downloading by rsp4jack · Pull Request #37 · pedrolcl/sonivox · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve test dls downloading #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2025
Merged

Improve test dls downloading #37

merged 2 commits into from
Jan 1, 2025

Conversation

rsp4jack
Copy link
Collaborator
@rsp4jack rsp4jack commented Jan 1, 2025

Raise an error when a temp dir cannot be found

pedrolcl
pedrolcl reviewed Jan 1, 2025
View reviewed changes
pedrolcl
pedrolcl requested changes Jan 1, 2025
View reviewed changes
Copy link
Owner
@pedrolcl pedrolcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should check as well that ${SOUNDFONT} has been downloaded correctly by comparing size and hash.

@pedrolcl
Copy link
Owner
pedrolcl commented Jan 1, 2025

This is very related to #36

@rsp4jack rsp4jack requested a review from pedrolcl January 1, 2025 12:02
@rsp4jack
Copy link
Collaborator Author
rsp4jack commented Jan 1, 2025

BTW It would be better to have a minimal testing DLS rather than download a big file from the Internet (~78 MiB), which is not very reliable.

@pedrolcl
Copy link
Owner
pedrolcl commented Jan 1, 2025

BTW It would be better to have a minimal testing DLS rather than download a big file from the Internet (~78 MiB), which is not very reliable.

A small file may not be good enough for testing purposes, and to include any DLS file on the repository it needs to have a license compatible with Apache 2. I don't know a single example fulfilling both conditions.

@pedrolcl pedrolcl merged commit 9b337bc into pedrolcl:devel Jan 1, 2025
8 checks passed
This was referenced Apr 4, 2025
Closed
Merged
pedrolcl added a commit that referenced this pull request Apr 5, 2025
@pedrolcl
Merge 71E3 pull request #44 from rsp4jack/dlstest
8545f66 
Addition fix of #37: fix SonivoxTestEnvironment getTmp()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrolcl pedrolcl pedrolcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsp4jack @pedrolcl
0