8000 EDTF extended date parsing by missinglink · Pull Request #60 · pelias/wof · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

EDTF extended date parsing #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

EDTF extended date parsing #60

merged 1 commit into from
Apr 23, 2025

Conversation

missinglink
Copy link
Member

This PR resolves whosonfirst-data/whosonfirst-data#2246

I originally intended to check for the strings ['uuuu', '', 'open', '..'] but ended up simply checking if the string contains a number, which has the benefit of working with all of these values without explicitly specifying them.

ref: https://mormonplaces.byu.edu/edtf.html

@missinglink missinglink mentioned this pull request Apr 23, 2025
Closed
@missinglink
Copy link
Member Author

I spot checked a couple of the features where the cessation tag was 'open' and they are both currently active airports, so returning false to isCeased() is correct for these:

@missinglink
Copy link
Member Author
missinglink commented Apr 23, 2025 •
edited
Loading

I think technically a date range such as 2014-04-15.. (ie. with an 'open' end) should return false, however this isn't accounted for in either the Go or Python codebases and doesn't currently present itself in data, so I'll leave that as a future improvement.

@missinglink missinglink merged commit ea250f7 into master Apr 23, 2025
6 checks passed
@missinglink missinglink deleted the edtf-extended branch April 23, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why are continents is_ceased?
1 participant
@missinglink
0