Add AuthZen tenant and inline attributes support #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `validation_error` method in `AuthZenError` for handling JSON schema validation failures. - Updated error handling in the evaluation logic to return detailed validation error messages for unprocessable entities (422). - Refactored request conversion logic 8000 in `evaluation.rs`, `schema.rs`, and `search_action.rs` to streamline property extraction and improve clarity. - Added comprehensive tests for resource and subject conversions, ensuring correct handling of attributes and properties.
- Simplified the extraction of properties and attributes in `evaluation.rs`, `schema.rs`, and `search_action.rs`. - Removed unnecessary nested structures for attributes, enhancing clarity in the code. - Updated tests to reflect the new structure and ensure accurate handling of resource and subject properties. - Improved overall readability and maintainability of the AuthZen API integration.
- Updated `AuthZenResource` and `AuthZenSubject` to use `Option<String>` for IDs, allowing for better default handling and serialization. - Modified related search and action request structures to accommodate the new ID types. - Adjusted tests to reflect changes in resource ID handling and ensure compatibility with the updated structures. - Enhanced overall clarity and maintainability of the AuthZen API integration.
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on June 18, 2025
You have used $0.00 of your $20.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
omer9564
reviewed
Jun 16, 2025
- Updated the conversion implementation for `ResourceSearchRequest` to extract properties directly from the resource instead of the context, improving clarity and consistency. - Adjusted the handling of the context field to maintain compatibility with existing structures. - Added an empty "id" field to the resource type in tests to ensure proper structure and validation.
omer9564
approved these changes
Jun 17, 2025
| @@ -55,12 +46,14 @@ pub struct ResourceSearchResponse { | |||
| // Convert AuthZen request to UserPermissionsQuery | |||
| impl From<ResourceSearchRequest> for UserPermissionsQuery { | |||
| fn from(req: ResourceSearchRequest) -> Self { | |||
| let mut properties = req.resource.properties.unwrap_or_default(); | |||
| let tenant = properties.remove("tenant").map(|v| v.to_string()); | |||
There was a problem hiding this comment.
You can also have resources = req.resource.map(|v| vec!(v))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validation_errormethod inAuthZenErrorfor handling JSON schema validation failures.evaluation.rs,schema.rs, andsearch_action.rsto streamline property extraction and improve clarity.