feature: healthcheck ready wait for all data sources load #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #801
Changes proposed
This PR:
🌟 Adds a query to the
/readyendpoint, defaults to false to maintain current behaviour.🌟 Propagates the query through the system to the
is_readyhealthcheck method🌟 If the query parameter = True, then we mark the system as 'ready' when the number of successful data transactions matches the total number of expected data transactions (defined from the opal data config sources)
/healthyendpoint should check the system is 'ready' (as defined by the ready endpoint) with a little extra too. However, I have not touched the/healthycode here.Check List (Check all the applicable boxes)
Screenshots
Note to reviewers