refactor: Docusaurus to version 3.7 #499
Conversation
* update react to 18 * update MDX from v2 to v3
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 37230bc |
|
@gemanor Just a note to update |
|
I will now upgrade Docusaurus to v7 and push their changes too and here the breaking change is it doesn't support prefix( |
|
@asr2003 that sounds good. We actually planning anyway to remove the v1.0.0 and redirect it to the home page of the current docs. @filipermit please set up the docs repo with Argos token |
|
@gemanor Can I remove the v1 docs and push a separate PR or can I get any upstream PR. It will make most of the work easy of this migration |
|
@gemanor @filipermit Here you need to get login this project in Argo portal then the workflow get access to run |
|
@asr2003 Thanks for the PR - I will run and test it today, and come back with any feedback I may have. V1 docs need to remain for reference to an older version. We might remove it at some point, but for the time being they need to stay. |
|
@filipermit afaik we already discussed about removing v1 (as it's not available to anyone anymore) Please check with @danielbass37 |
|
Hey, @asr2003, any news with the version update and the errors you experienced there? |
|
@gemanor Yes, I have updated few changes from version changes but I am just waiting on conformance whether we need v1 prefix sidebar or remove and get work easy |
|
You can remove the v1 (just need to make sure it has relevant redirects) |
|
Hey @asr2003 , @filipermit , any news here? |
|
@gemanor Just a conformation that I am trying to remove whole v1 directory and from sidebars too. Is this fine to goo? |
|
Yeah, I just approved it :) |
|
You can remove anything related to 1.0.0 from the repo, just make sure the pages has redirects |
|
@gemanor Mostly done the critical breaking changes to update to v3 from v2 and here the error occurring during build is due to version static build generation. I think you need to approve workflow to get your eye on it And another change is Once this two are done we are set to go now directly to update from v3 to v3..7 |
Approved the workflow but still not sure what is that mean :) Can you elaborate please? |
|
@gemanor Can you approve workflow now? You will exactly see the issue what I am intending to tell in docusaurus build stage |
|
Hey, I'm not sure what kind of help you need here, I guess the build error is something related to the upgrade - not something related to the content, right? |
|
Yes, I will try to find root cause of it |
|
Also see the comment in the issue page |
|
@gemanor I have found the issue of it why it not tying to build. I will fix it in weekend and push the code. I have my university exams for next 2 days. Will be back on it on Sunday. Meanwhile maybe we can merge the Argos workflow into master as I mentioned in issue comment |
@asr2003 Sounds good, we will be waiting for it.
I think we want to wait until everything passes. @gemanor can confirm here, but it seems like the more reasonable thing to do, especially for giving us the ability to test end-to-end. |
|
@asr2003 can you please open a PR with only Argos and Playwright (without version upgrade) so we can check if it passes and then we can merge it? |
|
Ok I will open it in my free time
…On Thu, 13 Feb, 2025, 9:31 pm Gabriel Manor, ***@***.***> wrote:
@asr2003 <https://github.com/asr2003> can you please open a PR with only
Argos and Playwright (without version upgrade) so we can check if it passes
and then we can merge it?
—
Reply to this email directly, view it on GitHub
<#499 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGXZB6BMA2EVDQD2ZINK3M32PS6V5AVCNFSM6AAAAABWDWTDBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJXGA2TMNJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: gemanor]*gemanor* left a comment (permitio/docs#499)
<#499 (comment)>
@asr2003 <https://github.com/asr2003> can you please open a PR with only
Argos and Playwright (without version upgrade) so we can check if it passes
and then we can merge it?
—
Reply to this email directly, view it on GitHub
<#499 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGXZB6BMA2EVDQD2ZINK3M32PS6V5AVCNFSM6AAAAABWDWTDBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJXGA2TMNJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@gemanor @filipermit The root cause is the docusaurus doesn't support path prefixes and it failing due to automatically handle of versioned sidebars in latest version. The docusaurus team responded and looking into them . As temporary fix I think we can either remove v1 /comment out it and make compile of current version only. What are your thoughts on this? |
|
As said, assuming we have redirects from all the 1.0.0 to the new home page, we are good with removing it. Please provide a working PR (without the 1.0.0) for our review, so we can proceed with it. |
|
ok then will push changes |
|
Just got few reference PRs from other projects of upgrading to 3.7. I experimenting it in another fresh branch, will merge with this branch and will mark ready for review once done |
|
Hey, @asr2003 |
|
@gemanor Check the opened PR of React. Actually the build issues aren't related of configuration but dependency migration issue . So I am aiming to refactor step by step to push small prs for each refactor to done so we can pinpoint what's the real cause of this build issues occuring |
|
Hey, I just merged the React upgrade, please share here your plans ahead |
No description provided.