Fixes #17; Removed obsolete undef #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkruzik
requested changes
Nov 24, 2022
There was a problem hiding this comment.
__FUNCT__ is used in some parts of the code and needs to be replaced by PETSC_FUNCTION_NAME which is defined as __func__. Therefore, printf using it like
permon/src/qp/interface/qpchain.c
Line 396 in 58b0ebb
need to replace it as
PetscCall(PetscViewerASCIIPrintf(v,"%s output follows\n",PETSC_FUNCTION_NAME));
For a reference, this PR removed __FUNCT__ from PETSc https://gitlab.com/petsc/petsc/-/merge_requests/609
| @@ -2,11 +2,7 @@ | |||
| #include <permon/private/petscimpl.h> | |||
|
|
|||
| #if defined(MatCreateSeqSBAIJWithArrays) | |||
| #undef MatCreateSeqSBAIJWithArrays | |||
| #endif | |||
There was a problem hiding this comment.
this can't be deleted
I'll open an issue to review these fixes for PETSc functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.