-
-
Notifications
You must be signed in to change notification settings - Fork 245
pmdastatsd new QA and small agent changes #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
natoscott
merged 14 commits into
performancecopilot:master
from
Erbenos:python-pmdastatsd-qa
Feb 18, 2020
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5bddf33
(re-)started working on python tests for pmdastatsd, case exercising …
Erbenos d15d813
pmdastatsd qa: added cases for installation and removal of agent, def…
Erbenos b3364e2
fixed python .pyc artifact inclusion in git, fixed 1599.out verbose l…
Erbenos 4f071e3
Added labels test, duration metric type basic aggregation test
Erbenos 0eef0d2
removed debug artifact from 1599's test case and test output
Erbenos 5e27021
pmdastatsd 1599, added hdr histogram aggregation test case, added sim…
Erbenos 58f4076
pmdastatsd qa 1599, added test for verbose logging specificity, added…
Erbenos 2a2b9e4
pmdastatsd qa, added tests for max_udp_packet_size option, debug_outp…
Erbenos e814e6a
make metric value double type handling more consistent, aka allowed b…
Erbenos eccae28
pmdastatsd qa, added WIP valgrind-check case
Erbenos b14aab7
pmdastatsd qa, more work on valgrind test, moved 'config loaded' log …
Erbenos a524693
pmdastatsd qa, finished valgrind test
Erbenos 712815a
pmdastatsd improved clean up procedures
Erbenos 78b11bf
pmdastatsd qa 1599: added/modified GNUmakefile's/GNUmakefile.install'…
Erbenos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#!/bin/sh | ||
# PCP QA Test No. 1599 | ||
# Run each of the statsd PMDA ruby tests. | ||
# Run each of the statsd PMDA python tests. | ||
# | ||
# Copyright (c) 2019 Red Hat. | ||
# | ||
|
@@ -9,14 +9,11 @@ seq=`basename $0` | |
echo "QA output created by $seq" | ||
|
||
# get standard environment, filters and checks | ||
. ./common.product | ||
. ./common.filter | ||
. ./common.check | ||
. ./common.python | ||
|
||
test -e $PCP_PMDAS_DIR/statsd/pmdastatsd || _notrun "statsd PMDA not installed" | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment at the start of this file refering to 'ruby' needs updating. |
||
# NOTE: Miroslav is planning to re-work this in python/shell | ||
which ruby >/dev/null 2>&1 || _notrun "ruby not installed" | ||
_check_valgrind | ||
|
||
_cleanup() | ||
{ | ||
|
@@ -28,41 +25,18 @@ status=1 # failure is the default! | |
$sudo rm -rf $tmp $tmp.* $seq.full | ||
trap "_cleanup; exit \$status" 0 1 2 3 15 | ||
|
||
pmdastatsd_remove() | ||
{ | ||
echo | ||
echo "=== remove statsd agent ===" | ||
cd $PCP_PMDAS_DIR/statsd | ||
$sudo ./Remove >$tmp.out 2>&1 | ||
_filter_pmda_remove <$tmp.out | ||
} | ||
|
||
pmdastatsd_install() | ||
{ | ||
echo | ||
echo "=== statsd agent installation ===" | ||
cd $PCP_PMDAS_DIR/statsd | ||
$sudo ./Install </dev/null >$tmp.out 2>&1 | ||
cat $tmp.out >>$here/$seq.full | ||
_filter_pmda_install <$tmp.out | ||
} | ||
|
||
_prepare_pmda statsd | ||
# note: _restore_auto_restart pmcd done in _cleanup_pmda() | ||
trap "_cleanup_pmda statsd; exit \$status" 0 1 2 3 15 | ||
_stop_auto_restart pmcd | ||
|
||
# real QA test starts here | ||
pmdastatsd_install | ||
|
||
cd $here/statsd | ||
scripts=`ls *.rb | LC_COLLATE=POSIX sort` | ||
cd $here/statsd/src | ||
scripts=`find cases -name *.py | LC_COLLATE=POSIX sort` | ||
for script in $scripts | ||
do | ||
ruby $script | ||
$python $script $here/statsd/output | ||
done | ||
cd $here | ||
|
||
pmdastatsd_remove | ||
status=0 | ||
exit |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider replacing the above three lines with common.python now.